BUG: Fix move_into_mutable_buffer for python 3.6. #14695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llllllllll
force-pushed
the
move-3.6-compat
branch
from
db7fd72 to
bdf4192
Compare
jreback
added
the
Compat
llllllllll
force-pushed
the
move-3.6-compat
branch
from
bdf4192 to
82b3b85
Compare
Current coverage is 85.20% (diff: 100%)@@ master #14695 diff @@
==========================================
Files 143 143
Lines 50787 50787
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43273 43274 +1
+ Misses 7514 7513 -1
Partials 0 0
|
llllllllll
force-pushed
the
move-3.6-compat
branch
from
82b3b85 to
d1e8b1b
Compare
In python 3.6, the CALL_FUNCTION handling was updated. One change is that when calling a C function from a python function python now counts the reference owned by the argument tuple. This means that move was always seeing objects with two references instead of the expected one. Python 3.6 also removed a copy in the argument tuple when *unpacking functions. This means that if a user does: tuple = (create_string(),) move_into_mutable_buffer(*tuple) where create_string() creates a string object with one reference then we will fail to raise a BadMove even though the user could later retrieve that string with tuple[0]. There is no way to detect this case so this patch adds a warning to the docstring advising against star unpacking.
|
ping: tests passing now. |
|
thanks @llllllllll |
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Dec 14, 2016
…hon 3.6. In python 3.6, the CALL_FUNCTION handling was updated. One change is that when calling a C function from a python function python now counts the reference owned by the argument tuple. This means that move was always seeing objects with two references instead of the expected one. Python 3.6 also removed a copy in the argument tuple when *unpacking functions. This means that if a user does: tuple = (create_string(),) move_into_mutable_buffer(*tuple) where create_string() creates a string object with one reference then we will fail to raise a BadMove even though the user could later retrieve that string with tuple[0]. There is no way to detect this case so this patch adds a warning to the docstring advising against star unpacking. xref: pandas-dev#14679 I played around with removing the extra reference that was added in 3.6 but it looks like playing with borrowed refs everywhere will be a bit tricky. This change should clear things up for 3.6 while continuing to work for older versions. In 3.6 you __could__ get a shared mutable string from this but you need to try pretty hard for it. Author: Joe Jevnik <[email protected]> Closes pandas-dev#14695 from llllllllll/move-3.6-compat and squashes the following commits: d1e8b1b [Joe Jevnik] BUG: Fix move_into_mutable_buffer for python 3.6. (cherry picked from commit f609640)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python 3.6, the CALL_FUNCTION handling was updated. One change is
that when calling a C function from a python function python now counts
the reference owned by the argument tuple. This means that move was
always seeing objects with two references instead of the expected
one.
Python 3.6 also removed a copy in the argument tuple when *unpacking
functions. This means that if a user does:
tuple = (create_string(),)
move_into_mutable_buffer(*tuple)
where create_string() creates a string object with one reference then we
will fail to raise a BadMove even though the user could later retrieve
that string with tuple[0]. There is no way to detect this case so this
patch adds a warning to the docstring advising against star unpacking.
xref: #14679
I played around with removing the extra reference that was added in 3.6 but it looks like playing with borrowed refs everywhere will be a bit tricky. This change should clear things up for 3.6 while continuing to work for older versions. In 3.6 you could get a shared mutable string from this but you need to try pretty hard for it.