TST: Test datetime array assignment with different units (#7492) #14884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # OutOfBoundsDatetime error shouldn't occur | ||
| data_s = np.array([1, 'nat'], dtype='datetime64[s]') | ||
| result['new'] = data_s | ||
| expected = pd.DataFrame({0: data_ns, 'new': data_s}) |
There was a problem hiding this comment.
Probably not needed to assert the original bug, but I would create the expected frame independently of data_s (eg pd.DataFrame({0:[1e9, None], 'new': [1e9, None]}, dtype='datetime64[ns]'))
There was a problem hiding this comment.
Thanks for the guidance! I'll make that change later tonight.
jorisvandenbossche
added
Testing
Current coverage is 85.30% (diff: 100%)
|
|
Changes made and all green. |
|
@mroeschke Thanks! |
ischurov
pushed a commit
to ischurov/pandas
that referenced
this pull request
Dec 19, 2016
ShaharBental
pushed a commit
to ShaharBental/pandas
that referenced
this pull request
Dec 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffThe example in this issue currently works in master. Added a test to confirm. Based on a quick skim of the recent PRs, doesn't look like it was fixed recently.