Skip to content

CLN: [WIP] trial pull-request to make sure everything is in order before proceeding (GH14468) #15866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

CLN: [WIP] trial pull-request to make sure everything is in order before proceeding (GH14468) #15866

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fbc3543
CLN: added typing requirements for python 2.7. GH14468
brmc Mar 19, 2017
463ef16
revert algos
TomAugspurger May 8, 2017
d606649
CFG: Put config in setup.cfg
TomAugspurger May 8, 2017
0bf7a19
DOC: Start docs on mypy
TomAugspurger May 8, 2017
76126f2
COMPAT: Catch ImportError from hinting
TomAugspurger May 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ matrix:
- python-gtk2
- os: linux
env:
- JOB="3.5" TEST_ARGS="--skip-slow --skip-network" COVERAGE=true
- JOB="3.5" TEST_ARGS="--skip-slow --skip-network" COVERAGE=true TYPING=true
addons:
apt:
packages:
Expand Down Expand Up @@ -116,6 +116,7 @@ script:
- ci/script_single.sh
- ci/script_multi.sh
- ci/lint.sh
- ci/typing.sh
- echo "script done"

after_success:
Expand Down
4 changes: 4 additions & 0 deletions ci/install_travis.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,10 @@ if [ "$LINT" ]; then
pip install cpplint
fi

if [ "$TYPING" ]; then
pip install mypy-lang
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mypy-lang is now called just mypy. I'll update in my branch.

fi

if [ "$COVERAGE" ]; then
pip install coverage pytest-cov
fi
Expand Down
1 change: 1 addition & 0 deletions ci/requirements-2.7.pip
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ py
PyCrypto
mock
ipython
typing
23 changes: 23 additions & 0 deletions ci/typing.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#!/bin/bash

echo "inside $0"

source activate pandas

RET=0

if [ "$TYPING" ]; then

echo "Typing *.py"
mypy \
pandas/core/base.py
if [ $? -ne "0" ]; then
RET=1
fi
echo "Typing *.py DONE"

else
echo "NOT checking typing"
fi

exit $RET
Loading