-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: update install.rst to include ActivePython distribution #19908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find any information about ActivePython being a distribution that included pandas and its dependencies, so I find it a bit strange to list it here. Eg http://docs.activestate.com/activepython/3.6/pkg/ does not list it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback If you prefer it to say something else, let me know. That is the page where they've requested we list the ActivePython distribution. If it's better to leave it off the last sentence, I'm sure that's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with it being listed as a way to install python (the other edits), but just as far as I can see (I don't know it, I just go from what I find on their website) it is not a distribution that includes pandas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this place is fine. I tihnk @jorisvandenbossche is just asking whether activestate is like 'Anaconda' in that it includes pandas (I think no?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't actually know the answer to that question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've asked them to weigh in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Dr-G,
Thanks for the opportunity to clarify. Our distributions for Python 2.7.14 and 3.5.4 include Pandas, its dependencies, and many of the optional dependencies. @jorisvandenbossche is correct that our Python 3.6 distribution doesn't currently include Pandas. We will be updating the package list to match 3.5.4 at some point in the next few months. We're just starting to see demand for 3.6 from our enterprise customers.
For now, could the last sentence read something similar to the following:
A packaged distribution like Anaconda, Enthought Canopy, or ActivePython (version 2.7 or 3.5) may be worth considering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback are we all set with this? Let me know if you need me to do anything/make any changes. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davetlewis-van Thanks for the clarification. That explains why I couldn't find it with for python 3.6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the version clarification in #19964. @davetlewis-van Once version 3.6 is updated to include pandas, feel free to do a PR to update the instructions.