Skip to content

CLN: Deprecate Index.summary (GH18217) #20028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v0.23.0.txt
Original file line number Diff line number Diff line change
Expand Up @@ -736,6 +736,7 @@ Deprecations
- :attr:`Timestamp.weekday_name`, :attr:`DatetimeIndex.weekday_name`, and :attr:`Series.dt.weekday_name` are deprecated in favor of :meth:`Timestamp.day_name`, :meth:`DatetimeIndex.day_name`, and :meth:`Series.dt.day_name` (:issue:`12806`)

- ``pandas.tseries.plotting.tsplot`` is deprecated. Use :func:`Series.plot` instead (:issue:`18627`)
- ``Index.summary()`` is deprecated and will be removed in a future version (:issue:`18217`)

.. _whatsnew_0230.prior_deprecations:

Expand Down
2 changes: 1 addition & 1 deletion pandas/core/frame.py
Original file line number Diff line number Diff line change
Expand Up @@ -2005,7 +2005,7 @@ def info(self, verbose=None, buf=None, max_cols=None, memory_usage=None,
lines = []

lines.append(str(type(self)))
lines.append(self.index.summary())
lines.append(self.index._summary())

if len(self.columns) == 0:
lines.append('Empty %s' % type(self).__name__)
Expand Down
24 changes: 23 additions & 1 deletion pandas/core/indexes/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -1385,7 +1385,19 @@ def _has_complex_internals(self):
# to disable groupby tricks in MultiIndex
return False

def summary(self, name=None):
def _summary(self, name=None):
"""
Return a summarized representation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need a deprecated tag on the _summary methods


Parameters
----------
name : str
name to use in the summary representation

Returns
-------
String with a summarized representation of the index
"""
if len(self) > 0:
head = self[0]
if (hasattr(head, 'format') and
Expand All @@ -1404,6 +1416,16 @@ def summary(self, name=None):
name = type(self).__name__
return '%s: %s entries%s' % (name, len(self), index_summary)

def summary(self, name=None):
"""
Return a summarized representation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a Parameters & Returns section

.. deprecated:: 0.23.0
No longer supported
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need the 'No longer supported'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback - This has been removed per your request. Update has been pushed.

"""
warnings.warn("'summary' is deprecated and will be removed in a "
"future version.", FutureWarning, stacklevel=2)
return self._summary(name)

def _mpl_repr(self):
# how to represent ourselves to matplotlib
return self.values
Expand Down
13 changes: 11 additions & 2 deletions pandas/core/indexes/datetimelike.py
Original file line number Diff line number Diff line change
Expand Up @@ -1049,9 +1049,18 @@ def where(self, cond, other=None):
return self._shallow_copy(result,
**self._get_attributes_dict())

def summary(self, name=None):
def _summary(self, name=None):
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the doc-strings here (and in the base class)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback - What specific updates were you referring to? Do the sphinx tags need to be added here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need deprecated in the _summary doc-strings

return a summarized representation
Return a summarized representation

Parameters
----------
name : str
name to use in the summary representation

Returns
-------
String with a summarized representation of the index
"""
formatter = self._formatter_func
if len(self) > 0:
Expand Down
19 changes: 10 additions & 9 deletions pandas/tests/indexes/datetimes/test_formats.py
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ def test_dti_summary(self):

for idx, expected in zip([idx1, idx2, idx3, idx4, idx5, idx6],
[exp1, exp2, exp3, exp4, exp5, exp6]):
result = idx.summary()
result = idx._summary()
assert result == expected

def test_dti_business_repr(self):
Expand All @@ -191,15 +191,15 @@ def test_dti_business_repr(self):

def test_dti_business_summary(self):
rng = pd.bdate_range(datetime(2009, 1, 1), datetime(2010, 1, 1))
rng.summary()
rng[2:2].summary()
rng._summary()
rng[2:2]._summary()

def test_dti_business_summary_pytz(self):
pd.bdate_range('1/1/2005', '1/1/2009', tz=pytz.utc).summary()
pd.bdate_range('1/1/2005', '1/1/2009', tz=pytz.utc)._summary()

def test_dti_business_summary_dateutil(self):
pd.bdate_range('1/1/2005', '1/1/2009',
tz=dateutil.tz.tzutc()).summary()
tz=dateutil.tz.tzutc())._summary()

def test_dti_custom_business_repr(self):
# only really care that it works
Expand All @@ -209,12 +209,13 @@ def test_dti_custom_business_repr(self):
def test_dti_custom_business_summary(self):
rng = pd.bdate_range(datetime(2009, 1, 1), datetime(2010, 1, 1),
freq='C')
rng.summary()
rng[2:2].summary()
rng._summary()
rng[2:2]._summary()

def test_dti_custom_business_summary_pytz(self):
pd.bdate_range('1/1/2005', '1/1/2009', freq='C', tz=pytz.utc).summary()
pd.bdate_range('1/1/2005', '1/1/2009', freq='C',
tz=pytz.utc)._summary()

def test_dti_custom_business_summary_dateutil(self):
pd.bdate_range('1/1/2005', '1/1/2009', freq='C',
tz=dateutil.tz.tzutc()).summary()
tz=dateutil.tz.tzutc())._summary()
2 changes: 1 addition & 1 deletion pandas/tests/indexes/period/test_formats.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,5 +205,5 @@ def test_summary(self):
idx6, idx7, idx8, idx9],
[exp1, exp2, exp3, exp4, exp5,
exp6, exp7, exp8, exp9]):
result = idx.summary()
result = idx._summary()
assert result == expected
11 changes: 9 additions & 2 deletions pandas/tests/indexes/test_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -1055,14 +1055,21 @@ def test_is_all_dates(self):
assert not self.intIndex.is_all_dates

def test_summary(self):
self._check_method_works(Index.summary)
self._check_method_works(Index._summary)
# GH3869
ind = Index(['{other}%s', "~:{range}:0"], name='A')
result = ind.summary()
result = ind._summary()
# shouldn't be formatted accidentally.
assert '~:{range}:0' in result
assert '{other}%s' in result

# GH18217
def test_summary_deprecated(self):
ind = Index(['{other}%s', "~:{range}:0"], name='A')

with tm.assert_produces_warning(FutureWarning):
ind.summary()

def test_format(self):
self._check_method_works(Index.format)

Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/indexes/timedeltas/test_formats.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,5 +92,5 @@ def test_summary(self):

for idx, expected in zip([idx1, idx2, idx3, idx4, idx5],
[exp1, exp2, exp3, exp4, exp5]):
result = idx.summary()
result = idx._summary()
assert result == expected