-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DEPR: deprecate get_ftype_counts (GH18243) #20404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TomAugspurger
merged 6 commits into
pandas-dev:master
from
GGordonGordon:GH18243_deprecate_get_ftype_counts
Mar 27, 2018
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fd811f9
DOC: update the Index.isin docstring (#20249)
noemielteto 4a0e2b3
DEPR: deprecate get_ftype_counts (GH18243)
GGordonGordon e7b8bf0
DEPR: deprecate get_ftype_counts (GH18243)
GGordonGordon 7bab84d
DEPR: deprecate get_ftype_counts (GH18243)
GGordonGordon 59c4bff
DEPR: deprecate get_ftype_counts (GH18243)
GGordonGordon 26268d9
DEPR: deprecate get_ftype_counts (GH18243)
GGordonGordon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,8 +64,10 @@ def test_dtype(self): | |
assert self.ts.ftypes == 'float64:dense' | ||
tm.assert_series_equal(self.ts.get_dtype_counts(), | ||
Series(1, ['float64'])) | ||
tm.assert_series_equal(self.ts.get_ftype_counts(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just assert the warning here |
||
Series(1, ['float64:dense'])) | ||
# GH18243 - Assert .get_ftype_counts is deprecated | ||
with tm.assert_produces_warning(FutureWarning): | ||
tm.assert_series_equal(self.ts.get_ftype_counts(), | ||
Series(1, ['float64:dense'])) | ||
|
||
@pytest.mark.parametrize("value", [np.nan, np.inf]) | ||
@pytest.mark.parametrize("dtype", [np.int32, np.int64]) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to create another function here, this is purely user facing (IOW don't create a _get_ftype_counts). keep the doc-string though.