Skip to content

Index union sort hack #20809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

toobaz
Copy link
Member

@toobaz toobaz commented Apr 24, 2018

This is an attempt to adapt #17378 according to @gfyoung 's suggestions.

(I do plan to investigate more in depth the problem in Windows, I just won't be able to do it soon)

@gfyoung
Copy link
Member

gfyoung commented Apr 24, 2018

@toobaz : Just to confirm: does this supersede #17378 (i.e. should we close that?)

Curious to see if AppVeyor will be more accommodating to this PR.

@toobaz toobaz force-pushed the index_union_sort_hack branch from 8d2e40d to c07e91e Compare April 24, 2018 10:52
@toobaz
Copy link
Member Author

toobaz commented Apr 24, 2018

@toobaz : Quick question: does this supersede #17378 (i.e. should we close that?)

... if this passes tests, I guess we will.

@gfyoung
Copy link
Member

gfyoung commented Apr 24, 2018

...if this passes tests, I guess we will.

That's a good enough answer for me. 👍

@gfyoung gfyoung added Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode 2/3 Compat labels Apr 24, 2018
@jreback
Copy link
Contributor

jreback commented Oct 11, 2018

closing as stale, if you want to continue working, pls ping and we can re-open. you will need to merge master.

@jreback jreback closed this Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Union of indexes of tuples is not sorted
3 participants