BUG: _cython_table bug fix #22110
Merged
BUG: _cython_table bug fix #22110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
lgtm ping on green |
Codecov Report
@@ Coverage Diff @@
## master #22110 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 170 170
Lines 50705 50705
=======================================
Hits 46680 46680
Misses 4025 4025
Continue to review full report at Codecov.
|
|
All green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21224 introduced a bug, where the
conftest._cython_tableisn't sorted by the function's name, but by the functions class name (i.e. "function"). This can make the sorting indeterministic and make the build fail on Python 2.7 and 3.5 at times.This PR makes the sort order follow the functions names again and therefore be deterministic.