Skip to content

DOC: Fix flake8 issues in doc/source/whatsnew/v0.17.*.rst #24340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 2, 2019

Conversation

aqurilla
Copy link
Contributor

@aqurilla aqurilla commented Dec 18, 2018

@aqurilla
Copy link
Contributor Author

Hi! @datapythonista
I have a few queries regarding some changes - currently the output of
flake8-rst doc/source/whatsnew/v0.17.* is:

doc/source/whatsnew/v0.17.0.rst:177:22: E225 missing whitespace around operator
doc/source/whatsnew/v0.17.0.rst:177:22: E999 SyntaxError: invalid syntax
doc/source/whatsnew/v0.17.0.rst:177:26: E225 missing whitespace around operator
doc/source/whatsnew/v0.17.0.rst:750:14: E711 comparison to None should be 'if cond is None:'
doc/source/whatsnew/v0.17.0.rst:757:6: E711 comparison to None should be 'if cond is None:'
doc/source/whatsnew/v0.17.0.rst:772:12: E711 comparison to None should be 'if cond is None:'
doc/source/whatsnew/v0.17.1.rst:87:11: F821 undefined name 'DataFrame'

The errors on line 177 are due to df.plot.<TAB> - which is a valid operation in pandas but is giving an error here.

The next 3 errors are due to a comparison of a series vs None: s == None,
but an error is thrown requesting an if loop be added, along with its indentation block.

What would be the best way to resolve these?

@datapythonista
Copy link
Member

we fixed them before with a noqa comment. If you do a grep "<TAB>" doc/*, grep "== None"... you should find examples.

@datapythonista
Copy link
Member

also, please merge master and fix the conflicts when you update the PR

@datapythonista
Copy link
Member

@aqurilla do you have time to finish this PR?

@aqurilla
Copy link
Contributor Author

Hi @datapythonista yes, I was travelling and should be able to finish this by tomorrow

@datapythonista datapythonista self-assigned this Dec 30, 2018
@datapythonista
Copy link
Member

@aqurilla do you have time to finish this?

@codecov
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #24340 into master will increase coverage by 60.39%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24340       +/-   ##
===========================================
+ Coverage   31.88%   92.28%   +60.39%     
===========================================
  Files         166      162        -4     
  Lines       52413    51835      -578     
===========================================
+ Hits        16714    47834    +31120     
+ Misses      35699     4001    -31698
Flag Coverage Δ
#multiple 90.68% <ø> (+60.39%) ⬆️
#single 43% <ø> (+11.11%) ⬆️
Impacted Files Coverage Δ
pandas/core/computation/check.py 90.9% <0%> (-1.4%) ⬇️
pandas/core/dtypes/generic.py 100% <0%> (ø) ⬆️
pandas/core/arrays/__init__.py 100% <0%> (ø) ⬆️
pandas/core/arrays/numpy_.py
pandas/core/arrays/array_.py
pandas/core/arrays/_ranges.py
pandas/core/internals/arrays.py
pandas/util/_test_decorators.py 90.54% <0%> (+4.05%) ⬆️
pandas/core/config_init.py 99.24% <0%> (+9.84%) ⬆️
pandas/compat/__init__.py 58.3% <0%> (+10.03%) ⬆️
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5283ea...245d21e. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #24340 into master will increase coverage by 60.43%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24340       +/-   ##
===========================================
+ Coverage   31.88%   92.32%   +60.43%     
===========================================
  Files         166      166               
  Lines       52413    52440       +27     
===========================================
+ Hits        16714    48416    +31702     
+ Misses      35699     4024    -31675
Flag Coverage Δ
#multiple 90.75% <ø> (+60.45%) ⬆️
#single 43.01% <ø> (+11.12%) ⬆️
Impacted Files Coverage Δ
pandas/util/_test_decorators.py 90.54% <0%> (+4.05%) ⬆️
pandas/compat/__init__.py 57.91% <0%> (+9.65%) ⬆️
pandas/core/config_init.py 99.24% <0%> (+9.84%) ⬆️
pandas/core/reshape/util.py 100% <0%> (+11.53%) ⬆️
pandas/core/api.py 100% <0%> (+13.33%) ⬆️
pandas/compat/numpy/__init__.py 92.85% <0%> (+14.28%) ⬆️
pandas/io/formats/console.py 74.24% <0%> (+16.66%) ⬆️
pandas/core/dtypes/inference.py 98.46% <0%> (+18.46%) ⬆️
pandas/plotting/_compat.py 87.5% <0%> (+18.75%) ⬆️
pandas/core/indexes/api.py 99% <0%> (+20.79%) ⬆️
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5283ea...29c9163. Read the comment docs.

@aqurilla
Copy link
Contributor Author

aqurilla commented Jan 1, 2019

Hi @datapythonista , please have a look,
sorry for the delay!

@jreback jreback added this to the 0.24.0 milestone Jan 1, 2019
@jreback
Copy link
Contributor

jreback commented Jan 2, 2019

ping on green.

@aqurilla
Copy link
Contributor Author

aqurilla commented Jan 2, 2019

@jreback, please have a look

@jreback jreback merged commit f67c97e into pandas-dev:master Jan 2, 2019
@jreback
Copy link
Contributor

jreback commented Jan 2, 2019

thanks @aqurilla

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Fix flake8 issues in doc/source/whatsnew/v0.17.*.rst
3 participants