Skip to content

DOC: fix some doc build warnings/errors #24552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2019
Merged

DOC: fix some doc build warnings/errors #24552

merged 2 commits into from
Jan 2, 2019

Conversation

jorisvandenbossche
Copy link
Member

Some follow-ups on recent doc PRs

jorisvandenbossche
jorisvandenbossche commented Jan 2, 2019
View reviewed changes
doc/source/missing_data.rst
(s > 0).dtype
crit = (s > 0).reindex(list(range(8)))
crit
crit.dtype
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomAugspurger was there something specific you wanted to show with the above code? It seems you copied this from above about booleans becoming object, but which doesn't seem relevant for integer NA

(the actual fix here is the first line, you can't convert floats from random.randn to Integers)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall anything specific goal behind that example.

@jorisvandenbossche jorisvandenbossche mentioned this pull request Jan 2, 2019
Merged
@jreback jreback added the Docs label Jan 2, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 2, 2019
@jreback
Copy link
Contributor

jreback commented Jan 2, 2019

lgtm.

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #24552 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24552   +/-   ##
=======================================
  Coverage   92.33%   92.33%           
=======================================
  Files         166      166           
  Lines       52465    52465           
=======================================
  Hits        48443    48443           
  Misses       4022     4022
Flag Coverage Δ
#multiple 90.75% <ø> (ø) ⬆️
#single 42.99% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad0cfc...50264f3. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #24552 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24552   +/-   ##
=======================================
  Coverage   92.33%   92.33%           
=======================================
  Files         166      166           
  Lines       52465    52465           
=======================================
  Hits        48443    48443           
  Misses       4022     4022
Flag Coverage Δ
#multiple 90.75% <ø> (ø) ⬆️
#single 42.99% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad0cfc...50264f3. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 2, 2019 •
edited
Loading

Codecov Report

Merging #24552 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24552      +/-   ##
==========================================
- Coverage   92.33%   92.33%   -0.01%     
==========================================
  Files         166      166              
  Lines       52465    52465              
==========================================
- Hits        48443    48442       -1     
- Misses       4022     4023       +1
Flag Coverage Δ
#multiple 90.75% <ø> (ø) ⬆️
#single 43% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 87.59% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad0cfc...86a1b92. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Jan 2, 2019

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=6334 lint issues

@jreback jreback merged commit 4cf985a into pandas-dev:master Jan 2, 2019
@jreback
Copy link
Contributor

jreback commented Jan 2, 2019

thanks @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche deleted the doc-fixes branch January 2, 2019 17:07
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jorisvandenbossche @Pingviinituutti
DOC: fix some doc build warnings/errors (pandas-dev#24552)
6dfa838
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jorisvandenbossche @Pingviinituutti
DOC: fix some doc build warnings/errors (pandas-dev#24552)
9bc6640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jorisvandenbossche @jreback @TomAugspurger