Skip to content

REF: shift ravel in infer_dtype #24560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 3, 2019

Conversation

h-vetinari
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #24560 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24560      +/-   ##
==========================================
- Coverage   92.33%   92.31%   -0.02%     
==========================================
  Files         166      166              
  Lines       52465    52556      +91     
==========================================
+ Hits        48442    48519      +77     
- Misses       4023     4037      +14
Flag Coverage Δ
#multiple 90.74% <92.59%> (-0.02%) ⬇️
#single 43.05% <62.96%> (+0.05%) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/datetimes.py 98.01% <ø> (+0.09%) ⬆️
pandas/core/indexes/multi.py 95.58% <100%> (ø) ⬆️
pandas/core/reshape/tile.py 94.82% <100%> (ø) ⬆️
pandas/core/sorting.py 98.27% <100%> (ø) ⬆️
pandas/core/arrays/integer.py 96.29% <100%> (ø) ⬆️
pandas/core/dtypes/cast.py 88.72% <100%> (ø) ⬆️
pandas/core/dtypes/missing.py 93.18% <100%> (ø) ⬆️
pandas/core/internals/construction.py 96.66% <100%> (ø) ⬆️
pandas/plotting/_converter.py 63.82% <100%> (ø) ⬆️
pandas/core/series.py 93.53% <100%> (-0.11%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf985a...5fb02b8. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #24560 into master will not change coverage.
The diff coverage is 96.77%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24560   +/-   ##
=======================================
  Coverage   92.33%   92.33%           
=======================================
  Files         166      166           
  Lines       52544    52544           
=======================================
  Hits        48517    48517           
  Misses       4027     4027
Flag Coverage Δ
#multiple 90.76% <90.32%> (ø) ⬆️
#single 43.05% <64.51%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/timedeltas.py 88.1% <0%> (ø) ⬆️
pandas/core/indexes/multi.py 95.58% <100%> (ø) ⬆️
pandas/core/reshape/tile.py 94.82% <100%> (ø) ⬆️
pandas/core/arrays/datetimes.py 98.01% <100%> (ø) ⬆️
pandas/core/sorting.py 98.27% <100%> (ø) ⬆️
pandas/core/arrays/integer.py 96.29% <100%> (ø) ⬆️
pandas/core/dtypes/cast.py 88.72% <100%> (ø) ⬆️
pandas/core/dtypes/missing.py 93.18% <100%> (ø) ⬆️
pandas/core/internals/construction.py 96.66% <100%> (ø) ⬆️
pandas/plotting/_converter.py 63.82% <100%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b35fc...a040325. Read the comment docs.

@h-vetinari
Copy link
Contributor Author

@jreback
This is green, except two azure failures due to #24564

@jreback jreback added the Dtype Conversions Unexpected or buggy dtype conversions label Jan 3, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 3, 2019
@jreback
Copy link
Contributor

jreback commented Jan 3, 2019

lgtm ping on green.

@jreback jreback merged commit 9ad1e00 into pandas-dev:master Jan 3, 2019
@jreback
Copy link
Contributor

jreback commented Jan 3, 2019

thanks!

@h-vetinari h-vetinari deleted the infer_skipna_ravel branch January 3, 2019 09:56
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants