DTA Followups - remove redundant methods #24577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Jan 3, 2019
| @@ -400,98 +400,98 @@ def test_value_counts_unique_nunique(self): | |||
|
|
|||
| assert o.nunique() == len(np.unique(o.values)) | |||
|
|
|||
| def test_value_counts_unique_nunique_null(self): | |||
| @pytest.mark.parametrize('null_obj', [np.nan, None]) | |||
jreback
requested changes
Jan 3, 2019
| @@ -34,7 +34,7 @@ | |||
| _midnight = time(0, 0) | |||
|
|
|||
|
|
|||
| def _to_m8(key, tz=None): | |||
| def _to_M8(key, tz=None): | |||
There was a problem hiding this comment.
isn't the conversion just (line 50)
In [1]: from pandas._libs.tslibs import conversion
In [2]: ts = pd.Timestamp('20181001', tz='UTC')
In [3]: np.int64(conversion.pydt_to_i8(ts)).view('M8[ns]')
Out[3]: numpy.datetime64('2018-10-01T00:00:00.000000000')
In [5]: ts.to_datetime64()
Out[5]: numpy.datetime64('2018-10-01T00:00:00.000000000')
There was a problem hiding this comment.
this routine should really just be in conversion.pyx
There was a problem hiding this comment.
I’m hoping we can do something clever see #24576. Not sure we are internally consistent enough to do that yet though.
Codecov Report
@@ Coverage Diff @@
## master #24577 +/- ##
==========================================
+ Coverage 92.33% 92.36% +0.02%
==========================================
Files 166 166
Lines 52544 52494 -50
==========================================
- Hits 48517 48486 -31
+ Misses 4027 4008 -19
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #24577 +/- ##
==========================================
+ Coverage 92.33% 92.36% +0.02%
==========================================
Files 166 166
Lines 52544 52494 -50
==========================================
- Hits 48517 48486 -31
+ Misses 4027 4008 -19
Continue to review full report at Codecov.
|
jreback
approved these changes
Jan 3, 2019
|
thanks |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both arrays.datetimes and arrays.timedeltas have a
_to_m8function. The timedeltas one is removed since it is unnecessary, the datetimes one is given a more accurate name_to_M8A couple of unused funcs from
tmare removed.A test is parametrized.