-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DEPR: Fixed warning for implicit registration #24964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 5 commits into
pandas-dev:master
from
TomAugspurger:matplotlib-depr-warn
Jan 29, 2019
+6
−1
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b8bfb50
DEPR: Fixed warning for implicit registration
TomAugspurger 8a84ea5
fixed name
TomAugspurger 74560f2
skip py2
TomAugspurger d4b4d3e
remove tests
TomAugspurger f791e3d
Merge remote-tracking branch 'upstream/master' into matplotlib-depr-warn
TomAugspurger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# This test ensure that we warn for implicitly registered converters. | ||
# We isolate it completely, because its behavior depends on some global state | ||
# set at import time, which is tricky to get right. | ||
# We use unittest instead of pytest, since pytest will import pandas when | ||
# loading our conftest.py | ||
# https://github.com/pandas-dev/pandas/issues/24963 | ||
# https://github.com/pandas-dev/pandas/pull/18307 | ||
# TODO: Remove the special runner in ci/run_tests.sh | ||
import sys | ||
import unittest | ||
|
||
|
||
class TestConverter(unittest.TestCase): | ||
@unittest.skipIf("pandas" in sys.modules, "pandas musn't be imported.") | ||
def test_converter_warning(self): | ||
import pandas as pd | ||
import pandas.util.testing as tm | ||
try: | ||
import matplotlib.pyplot as plt | ||
except ImportError: | ||
return unittest.skip("No matplotlib") | ||
|
||
fig, ax = plt.subplots() | ||
ser = pd.Series(range(12), index=pd.date_range('2000', periods=12)) | ||
with tm.assert_produces_warning(FutureWarning, check_stacklevel=False): | ||
ax.plot(ser) | ||
|
||
|
||
if __name__ == '__main__': | ||
unittest.main() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any easier way to do this? this is introducing massive technical debt.