Skip to content

Reading a HDF5 created in py2 #25058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 4, 2019
Merged

Reading a HDF5 created in py2 #25058

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dd1ec02
Fix value error when reading dataframe saved in python 2 in python 3
radekbenesinno Jan 31, 2019
6871358
Typo fixed
radekbenesinno Jan 31, 2019
70c7ab1
Bug description
radekbenesinno Jan 31, 2019
0fa7102
Construct expected dataframe and assert outside of with statement
radekbenesinno Feb 1, 2019
f9ab133
Pep8 warning fixed
radekbenesinno Feb 1, 2019
5a7adc6
Merge branch 'master' of git://github.com/pandas-dev/pandas into Valu…
radekbenesinno Feb 1, 2019
abf6c35
Documentation updated, moved to 0.24.2
radekbenesinno Feb 1, 2019
1204301
Issue number is back in documentation
radekbenesinno Feb 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.24.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Bug Fixes

**I/O**

-
- Bug in reading a HDF5 table-format ``DataFrame`` created in Python 2, in Python 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add back the issue number reference

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 1204301

-
-

Expand Down
2 changes: 1 addition & 1 deletion pandas/io/pytables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3288,7 +3288,7 @@ def get_attrs(self):
self.nan_rep = getattr(self.attrs, 'nan_rep', None)
self.encoding = _ensure_encoding(
getattr(self.attrs, 'encoding', None))
self.errors = getattr(self.attrs, 'errors', 'strict')
self.errors = _ensure_decoded(getattr(self.attrs, 'errors', 'strict'))
self.levels = getattr(
self.attrs, 'levels', None) or []
self.index_axes = [
Expand Down
Binary file added pandas/tests/io/data/legacy_hdf/legacy_table_py2.h5
View file
Open in desktop
Binary file not shown.
17 changes: 16 additions & 1 deletion pandas/tests/io/test_pytables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4540,7 +4540,7 @@ def test_pytables_native2_read(self, datapath):

def test_legacy_table_fixed_format_read_py2(self, datapath):
# GH 24510
# legacy table with fixed format written en Python 2
# legacy table with fixed format written in Python 2
with ensure_clean_store(
datapath('io', 'data', 'legacy_hdf',
'legacy_table_fixed_py2.h5'),
Expand All @@ -4552,6 +4552,21 @@ def test_legacy_table_fixed_format_read_py2(self, datapath):
name='INDEX_NAME'))
assert_frame_equal(expected, result)

def test_legacy_table_read_py2(self, datapath):
# issue: 24925
# legacy table written in Python 2
with ensure_clean_store(
datapath('io', 'data', 'legacy_hdf',
'legacy_table_py2.h5'),
mode='r') as store:
result = store.select('table')

expected = pd.DataFrame({
"a": ["a", "b"],
"b": [2, 3]
})
assert_frame_equal(expected, result)

def test_legacy_table_read(self, datapath):
# legacy table types
with ensure_clean_store(
Expand Down