Skip to content

CLN: Remove PY2/3 checks in cython files #25876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2019
Merged

CLN: Remove PY2/3 checks in cython files #25876

merged 2 commits into from
Mar 26, 2019

Conversation

mroeschke
Copy link
Member

Remove PY2/3 checks in pyx files.

WillAyd
WillAyd reviewed Mar 26, 2019
View reviewed changes
pandas/_libs/lib.pyx Outdated
'U': 'unicode' if PY2 else 'string',
'string': 'bytes',
'S': 'bytes',
'unicode': 'string',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps orthogonal but maybe could remove this altogether?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. There are a couple of isinstance(..., unicode) checks but those can be removed in another PR.

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #25876 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25876   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files         175      175           
  Lines       52885    52885           
=======================================
  Hits        48380    48380           
  Misses       4505     4505
Flag Coverage Δ
#multiple 90.04% <ø> (ø) ⬆️
#single 41.82% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 324bb84...de2414b. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 26, 2019 •
edited
Loading

Codecov Report

Merging #25876 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25876   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files         175      175           
  Lines       52885    52885           
=======================================
  Hits        48380    48380           
  Misses       4505     4505
Flag Coverage Δ
#multiple 90.04% <ø> (ø) ⬆️
#single 41.82% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 324bb84...2716296. Read the comment docs.

@jreback jreback added this to the 0.25.0 milestone Mar 26, 2019
@jreback jreback merged commit b878f5b into pandas-dev:master Mar 26, 2019
@jreback
Copy link
Contributor

jreback commented Mar 26, 2019

thanks @mroeschke

@mroeschke mroeschke deleted the cython_py3 branch March 26, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd left review comments

@gfyoung gfyoung gfyoung approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mroeschke @jreback @WillAyd @gfyoung