CI/DOC: fix clipboard on travis #26103

saurav2608 · 2019-04-15T18:20:37Z

closes DOC: clipboard library missing in doc env on travis #26075

saurav2608 · 2019-04-15T18:55:43Z

this is more complex than what I thought. I will relook tomorrow.

codecov · 2019-04-15T18:59:34Z

Codecov Report

Merging #26103 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #26103      +/-   ##
==========================================
- Coverage   91.96%   91.95%   -0.01%     
==========================================
  Files         175      175              
  Lines       52405    52405              
==========================================
- Hits        48193    48189       -4     
- Misses       4212     4216       +4

Flag	Coverage Δ
#multiple	`90.51% <ø> (ø)`	⬆️
#single	`40.72% <ø> (-0.14%)`	⬇️

Impacted Files	Coverage Δ
pandas/io/gbq.py	`75% <0%> (-12.5%)`	⬇️
pandas/core/frame.py	`96.9% <0%> (-0.12%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90f9db...3b6b879. Read the comment docs.

codecov · 2019-04-15T18:59:38Z

Codecov Report

Merging #26103 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #26103      +/-   ##
==========================================
+ Coverage   91.69%   91.72%   +0.03%     
==========================================
  Files         174      174              
  Lines       50739    50741       +2     
==========================================
+ Hits        46523    46544      +21     
+ Misses       4216     4197      -19

Flag	Coverage Δ
#multiple	`90.23% <ø> (+0.03%)`	⬆️
#single	`41.68% <ø> (+0.36%)`	⬆️

Impacted Files	Coverage Δ
pandas/io/gbq.py	`78.94% <0%> (-10.53%)`	⬇️
pandas/core/frame.py	`97.02% <0%> (-0.12%)`	⬇️
pandas/util/testing.py	`90.7% <0%> (+0.1%)`	⬆️
pandas/core/generic.py	`93.49% <0%> (+0.14%)`	⬆️
pandas/io/clipboard/clipboards.py	`31.64% <0%> (+12.65%)`	⬆️
pandas/io/clipboard/__init__.py	`56.86% <0%> (+17.64%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c5165e...d8c6dc4. Read the comment docs.

saurav2608 · 2019-04-19T04:05:24Z

I am unable to replicate this in any of my environments. Thus I am create PRs to investigate.

jreback · 2019-04-20T18:47:06Z

@saurav2608 meaning the doc-build does not show any pyperclip error?

jreback · 2019-05-12T21:15:23Z

closing as stale

jorisvandenbossche · 2019-05-14T19:44:32Z

(reopened to try something out, based on the diff I noticed the use of export DISPLAY, and that it was in a different place before. Who knows that makes a difference ..)

jorisvandenbossche · 2019-05-15T10:23:51Z

@jreback OK?

(if this passes, will add a comment explaining why / referencing this PR)

jreback · 2019-05-15T11:01:11Z

so these are actually run? can u show that somewhere
maybe should make these tests highly visible somehow

jorisvandenbossche · 2019-05-15T11:09:36Z

What do you mean with "so these are actually run?" ?
Or is it a comment meant for a different PR? (there are no tests involved here, only for doc building)

jreback · 2019-05-15T12:10:49Z

@jorisvandenbossche we didn't notice that we should be running these (and weren't); I dont' think this has changed. We need a highly visible test that we can simply look in the logs and inspect (maybe just add a print statement to it).

https://travis-ci.org/pandas-dev/pandas/jobs/532738283

-----------------------------------------------------------------------------------------------------------------------------
#5 pandas.tests.test_algos.TestRank.test_pct_max_many_rows[1d]: skipping high memory test since --run-high-memory was not set
#6 pandas.tests.test_algos.TestRank.test_pct_max_many_rows[2d]: skipping high memory test since --run-high-memory was not set
------------------------------------------------------------------------------------------------------------------------------
#7 pandas.tests.frame.test_rank.TestRank.test_pct_max_many_rows: skipping high memory test since --run-high-memory was not set
-----------------------------------------------------------------------------------------------------------------
#8 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame[delims]: clipboard primitives not installed
#9 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame[utf8]: clipboard primitives not installed
#10 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame[utf16]: clipboard primitives not installed
#11 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame[string]: clipboard primitives not installed
#12 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame[long]: clipboard primitives not installed
#13 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame[nonascii]: clipboard primitives not installed
#14 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame[colwidth]: clipboard primitives not installed
#15 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame[mixed]: clipboard primitives not installed
#16 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame[float]: clipboard primitives not installed
#17 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame[int]: clipboard primitives not installed
#18 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame_sep[delims-\t]: clipboard primitives not installed
#19 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame_sep[delims-,]: clipboard primitives not installed
#20 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame_sep[delims-|]: clipboard primitives not installed
#21 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame_sep[utf8-\t]: clipboard primitives not installed
#22 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame_sep[utf8-,]: clipboard primitives not installed
#23 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame_sep[utf8-|]: clipboard primitives not installed
#24 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame_sep[utf16-\t]: clipboard primitives not installed
#25 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame_sep[utf16-,]: clipboard primitives not installed
#26 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame_sep[utf16-|]: clipboard primitives not installed
#27 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame_sep[string-\t]: clipboard primitives not installed
#28 pandas.tests.io.test_clipboard.TestClipboard.test_round_trip_frame_sep[string-,]: clipboard primitives not installed

jorisvandenbossche · 2019-05-15T12:39:44Z

Ah, so those tests have not been running on master for a while? (since the CI env refactor PR #24632), ok, I see now.

But it seems that this PR actually solves that. They are running again (just not on the first travis build, but if you look eg at the second travis build: https://travis-ci.org/pandas-dev/pandas/jobs/532738284: no message about skipped tests anymore. On the first travis build, they have been skipped even before the CI env refactor).

But not sure I understand why the first travis build (in the build matrix) would skip those and the second not. I don't see anything in their definition that can explain that (the clipboard tests are marked as 'single').

jorisvandenbossche · 2019-05-15T12:41:32Z

But not sure I understand why the first travis build (in the build matrix) would skip those and the second not.

Ah, maybe because the first build has no qt installed and the second does (through matplotlib), travis-37.yml vs travis-36-locale.yaml.

jreback · 2019-05-15T12:55:16Z

right I don't care that they run on all builds, but at least one. I think just add a print statement in the basic clip test might be enough here to provide us an easy visual reference.

jorisvandenbossche · 2019-05-16T08:51:22Z

@jreback I added some print statements, but they don't show up in the travis logs (although we have -s in the pytest command)

jreback · 2019-05-16T12:02:15Z

@jorisvandenbossche then how can we be sure these are actually run? This is the entire problem.

jorisvandenbossche · 2019-05-16T12:16:10Z

Well, you can say that for all other tests as well...
Unless we do -v to show each test that has been run.

jreback · 2019-05-16T12:29:27Z

Well, you can say that for all other tests as well...
Unless we do -v to show each test that has been run.

maybe, but this is a continual issue, and we need a foolproof way to say these tests are actually run

jorisvandenbossche · 2019-05-16T13:10:09Z

Will open an issue about that, but merging this since it is actually solving a problem

jorisvandenbossche · 2019-05-16T13:17:36Z

@saurav2608 thanks for putting me on the right track with the DISPLAY change !

saurav2608 · 2019-05-17T06:32:23Z

@saurav2608 thanks for putting me on the right track with the DISPLAY change !

@jorisvandenbossche Absolutely. I wish I could have contributed more. I am totally swamped at work.

add install for xsel

3b6b879

changed from xsel to xclip

41ef5c0

adding a test for xclip.

dddadf6

gfyoung added CI Continuous Integration Docs labels Apr 18, 2019

saurav-chakravorty added 2 commits April 18, 2019 13:17

added diagnostic message

6499667

change display variable.

257314d

saurav2608 changed the title ~~add install for xsel~~ add install for xsel (Do not merge) Apr 19, 2019

investigative messages

8df38fe

jreback closed this May 12, 2019

jorisvandenbossche reopened this May 14, 2019

add display in before_script

e097d62

jorisvandenbossche added 3 commits May 15, 2019 08:27

clean-up

896e3db

Merge remote-tracking branch 'upstream/master' into saurav2608-doc_xsel

d48deb5

move xvfb start to before_script

a297370

jorisvandenbossche changed the title ~~add install for xsel (Do not merge)~~ CI/DOC: fix clipboar in doc build on travis May 15, 2019

jorisvandenbossche changed the title ~~CI/DOC: fix clipboar in doc build on travis~~ CI/DOC: fix clipboard on travis May 15, 2019

jorisvandenbossche added 4 commits May 16, 2019 08:16

add print statement

d64a5bf

add comment

4dfe1cb

Merge remote-tracking branch 'upstream/master' into saurav2608-doc_xsel

db3dac4

try extra prints

a5b3edd

jreback added this to the 0.25.0 milestone May 16, 2019

remove printing

d8c6dc4

jorisvandenbossche merged commit 1263e1a into pandas-dev:master May 16, 2019

jorisvandenbossche mentioned this pull request May 16, 2019

CI: how to ensure certain tests have been run #26428

Open

datapythonista mentioned this pull request Jun 7, 2019

DOC: Not running clipboard examples in the doc #26700

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI/DOC: fix clipboard on travis #26103

CI/DOC: fix clipboard on travis #26103

saurav2608 commented Apr 15, 2019

saurav2608 commented Apr 15, 2019

codecov bot commented Apr 15, 2019

codecov bot commented Apr 15, 2019 •

edited

Loading

saurav2608 commented Apr 19, 2019

jreback commented Apr 20, 2019

jreback commented May 12, 2019

jorisvandenbossche commented May 14, 2019

jorisvandenbossche commented May 15, 2019

jreback commented May 15, 2019

jorisvandenbossche commented May 15, 2019

jreback commented May 15, 2019

jorisvandenbossche commented May 15, 2019

jorisvandenbossche commented May 15, 2019

jreback commented May 15, 2019

jorisvandenbossche commented May 16, 2019

jreback commented May 16, 2019

jorisvandenbossche commented May 16, 2019

jreback commented May 16, 2019

jorisvandenbossche commented May 16, 2019

jorisvandenbossche commented May 16, 2019

saurav2608 commented May 17, 2019

CI/DOC: fix clipboard on travis #26103

CI/DOC: fix clipboard on travis #26103

Conversation

saurav2608 commented Apr 15, 2019

saurav2608 commented Apr 15, 2019

codecov bot commented Apr 15, 2019

Codecov Report

codecov bot commented Apr 15, 2019 • edited Loading

Codecov Report

saurav2608 commented Apr 19, 2019

jreback commented Apr 20, 2019

jreback commented May 12, 2019

jorisvandenbossche commented May 14, 2019

jorisvandenbossche commented May 15, 2019

jreback commented May 15, 2019

jorisvandenbossche commented May 15, 2019

jreback commented May 15, 2019

jorisvandenbossche commented May 15, 2019

jorisvandenbossche commented May 15, 2019

jreback commented May 15, 2019

jorisvandenbossche commented May 16, 2019

jreback commented May 16, 2019

jorisvandenbossche commented May 16, 2019

jreback commented May 16, 2019

jorisvandenbossche commented May 16, 2019

jorisvandenbossche commented May 16, 2019

saurav2608 commented May 17, 2019

codecov bot commented Apr 15, 2019 •

edited

Loading