Skip to content

CLN: remove unused code check for pytest.raises #26435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

simonjayhawkins
Copy link
Member

xref #25866

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #26435 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26435      +/-   ##
==========================================
- Coverage   91.73%   91.72%   -0.01%     
==========================================
  Files         174      174              
  Lines       50741    50741              
==========================================
- Hits        46548    46544       -4     
- Misses       4193     4197       +4
Flag Coverage Δ
#multiple 90.23% <ø> (ø) ⬆️
#single 41.68% <ø> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1263e1a...98e7e6c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #26435 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26435      +/-   ##
==========================================
- Coverage   91.73%   91.72%   -0.01%     
==========================================
  Files         174      174              
  Lines       50741    50741              
==========================================
- Hits        46548    46544       -4     
- Misses       4193     4197       +4
Flag Coverage Δ
#multiple 90.23% <ø> (ø) ⬆️
#single 41.68% <ø> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1263e1a...98e7e6c. Read the comment docs.

@jreback jreback added the Clean label May 17, 2019
@jreback jreback added this to the 0.25.0 milestone May 17, 2019
@jreback
Copy link
Contributor

jreback commented May 17, 2019

wait, shouldn't we just turn this check on?

@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented May 17, 2019 via email

@jreback jreback merged commit 84b11bc into pandas-dev:master May 17, 2019
@simonjayhawkins simonjayhawkins deleted the code-checks-pytest-raises branch May 17, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants