Annotate DataFrame (Part 1) #26867

vaibhavhrt · 2019-06-15T11:54:02Z

Part of Annotate DataFrame (API exposed items from pandas.core.api) #26792
tests passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

vaibhavhrt

@WillAyd some feedback.
I will annotate these function in this PR. Functions after these are grouped using comments like, Rendering Methods, IO methods, etc. I will do one group of methods at a time after this.

pandas/core/frame.py

codecov · 2019-06-15T12:31:39Z

Codecov Report

Merging #26867 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #26867      +/-   ##
==========================================
- Coverage   91.88%   91.87%   -0.01%     
==========================================
  Files         179      179              
  Lines       50696    50701       +5     
==========================================
+ Hits        46581    46582       +1     
- Misses       4115     4119       +4

Flag	Coverage Δ
#multiple	`90.46% <100%> (ø)`	⬆️
#single	`41.09% <100%> (-0.08%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/frame.py	`96.89% <100%> (-0.11%)`	⬇️
pandas/io/gbq.py	`88.88% <0%> (-11.12%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 430f0fd...5e70e01. Read the comment docs.

codecov · 2019-06-15T12:31:44Z

Codecov Report

Merging #26867 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #26867      +/-   ##
==========================================
- Coverage      93%      93%   -0.01%     
==========================================
  Files         182      182              
  Lines       50311    50316       +5     
==========================================
+ Hits        46793    46794       +1     
- Misses       3518     3522       +4

Flag	Coverage Δ
#multiple	`91.67% <100%> (ø)`	⬆️
#single	`42.4% <100%> (-0.09%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/frame.py	`97.15% <100%> (-0.12%)`	⬇️
pandas/io/gbq.py	`88.88% <0%> (-11.12%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebcfee4...fba0fcc. Read the comment docs.

WillAyd

Looks great on first pass!

pandas/core/frame.py

vaibhavhrt

I think everything except type for data is done.

pandas/_typing.py

pandas/core/frame.py

pandas/_typing.py

pandas/core/frame.py

vaibhavhrt · 2019-07-17T11:24:17Z

Note to self: finish this.

pep8speaks · 2019-07-17T12:29:20Z

Hello @vaibhavhrt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-09-12 15:57:32 UTC

pandas/_typing.py

vaibhavhrt

@WillAyd some help

pandas/core/frame.py

vaibhavhrt · 2019-08-28T10:04:44Z

@WillAyd tests are passing, u can review now

pandas/_typing.py

jreback · 2019-09-10T12:02:27Z

lgtm. @WillAyd and @simonjayhawkins

simonjayhawkins

lgtm. a couple of suggestions.

pandas/core/frame.py

WillAyd

lgtm ex one comment

pandas/core/frame.py

Co-Authored-By: Simon Hawkins <[email protected]>

simonjayhawkins · 2019-09-12T10:05:12Z

@vaibhavhrt ci should be fixed. can you merge master. ping on green.

…ndas into annotate-DataFrame

simonjayhawkins · 2019-09-12T20:39:20Z

@WillAyd ok to merge?

simonjayhawkins · 2019-09-12T20:48:20Z

Thanks @vaibhavhrt

vaibhavhrt · 2019-09-13T05:23:26Z

part 2 coming this weekend, this one took too long(3 months 😰 ), will try to speed up.

vaibhavhrt added 2 commits June 15, 2019 17:20

type a few functions

bc01d66

fix flake errors

5e70e01

vaibhavhrt commented Jun 15, 2019

View reviewed changes

pandas/core/frame.py Outdated Show resolved Hide resolved

pandas/core/frame.py Show resolved Hide resolved

pandas/core/frame.py Show resolved Hide resolved

WillAyd requested changes Jun 15, 2019

View reviewed changes

pandas/core/frame.py Outdated Show resolved Hide resolved

pandas/core/frame.py Outdated Show resolved Hide resolved

pandas/core/frame.py Show resolved Hide resolved

WillAyd added the Typing type annotations, mypy/pyright type checking label Jun 15, 2019

minor changes

305329e

vaibhavhrt commented Jun 15, 2019

View reviewed changes

pandas/core/frame.py Outdated Show resolved Hide resolved

jreback requested changes Jun 16, 2019

View reviewed changes

pandas/core/frame.py Outdated Show resolved Hide resolved

pandas/core/frame.py Outdated Show resolved Hide resolved

pandas/core/frame.py Outdated Show resolved Hide resolved

create type for Axes in _typing and make parameters of __init__ optional

58a7da6

vaibhavhrt commented Jun 17, 2019

View reviewed changes

pandas/_typing.py Outdated Show resolved Hide resolved

pandas/core/frame.py Outdated Show resolved Hide resolved

WillAyd requested changes Jun 22, 2019

View reviewed changes

pandas/_typing.py Outdated Show resolved Hide resolved

pandas/core/frame.py Outdated Show resolved Hide resolved

vaibhavhrt force-pushed the annotate-DataFrame branch from 7189cd0 to b405d2d Compare July 17, 2019 12:32

update from master

691d1bb

vaibhavhrt force-pushed the annotate-DataFrame branch from b405d2d to 691d1bb Compare July 17, 2019 13:15

WIP type for data

c54642f

vaibhavhrt marked this pull request as ready for review July 17, 2019 13:32

vaibhavhrt commented Jul 17, 2019

View reviewed changes

pandas/_typing.py Outdated Show resolved Hide resolved

WillAyd requested changes Jul 17, 2019

View reviewed changes

pandas/_typing.py Outdated Show resolved Hide resolved

vaibhavhrt force-pushed the annotate-DataFrame branch from 2762f54 to 9f72713 Compare July 24, 2019 14:05

move types for 'data' in 'frame.py' from 'pandas._typing'

0fd42eb

vaibhavhrt force-pushed the annotate-DataFrame branch from 9f72713 to 0fd42eb Compare July 24, 2019 14:06

vaibhavhrt added 2 commits July 24, 2019 19:41

merge master

38bf4e0

use ABCDataFrame instead of 'DataFrame'

e413504

vaibhavhrt commented Jul 25, 2019

View reviewed changes

pandas/core/frame.py Outdated Show resolved Hide resolved

vaibhavhrt force-pushed the annotate-DataFrame branch from 221294d to 40001d6 Compare July 25, 2019 11:44

merge master

77f93fc

vaibhavhrt added 3 commits August 27, 2019 18:50

put Axes back in pandas._typing

2e65291

format with black

d99cc1a

Merge branch 'master' into annotate-DataFrame

c935b58

WillAyd requested changes Aug 30, 2019

View reviewed changes

pandas/_typing.py Outdated Show resolved Hide resolved

vaibhavhrt added 2 commits September 7, 2019 12:41

use Collection for Axes

1740ef2

merge origin

a118f67

vaibhavhrt requested a review from WillAyd September 7, 2019 07:16

revert Axes with comment

f2edb32

jreback approved these changes Sep 10, 2019

View reviewed changes

simonjayhawkins reviewed Sep 10, 2019

View reviewed changes

pandas/core/frame.py Outdated Show resolved Hide resolved

pandas/core/frame.py Outdated Show resolved Hide resolved

WillAyd reviewed Sep 10, 2019

View reviewed changes

pandas/core/frame.py Outdated Show resolved Hide resolved

Apply suggestions from code review

112f550

Co-Authored-By: Simon Hawkins <[email protected]>

vaibhavhrt requested review from simonjayhawkins and WillAyd September 11, 2019 09:06

vaibhavhrt and others added 3 commits September 12, 2019 16:26

Merge branch 'master' into annotate-DataFrame

8814eb3

Merge branch 'annotate-DataFrame' of https://github.com/vaibhavhrt/pa…

4d78c4b

…ndas into annotate-DataFrame

Update _typing.py

d03e33c

WillAyd approved these changes Sep 12, 2019

View reviewed changes

simonjayhawkins merged commit 3f40528 into pandas-dev:master Sep 12, 2019

vaibhavhrt deleted the annotate-DataFrame branch September 13, 2019 05:20

jmg7173 pushed a commit to jmg7173/pandas that referenced this pull request Sep 14, 2019

Annotate DataFrame (Part 1) (pandas-dev#26867)

d613d85

vaibhavhrt mentioned this pull request Sep 16, 2019

Annotate DataFrame (API exposed items from pandas.core.api) #26792

Closed

4 tasks

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019

Annotate DataFrame (Part 1) (pandas-dev#26867)

c48ef62

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019

Annotate DataFrame (Part 1) (pandas-dev#26867)

9b2f171

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Annotate DataFrame (Part 1) #26867

Annotate DataFrame (Part 1) #26867

vaibhavhrt commented Jun 15, 2019 •

edited

Loading

vaibhavhrt left a comment •

edited

Loading

codecov bot commented Jun 15, 2019

codecov bot commented Jun 15, 2019 •

edited

Loading

WillAyd left a comment

vaibhavhrt left a comment

vaibhavhrt commented Jul 17, 2019

pep8speaks commented Jul 17, 2019 •

edited

Loading

vaibhavhrt left a comment

vaibhavhrt commented Aug 28, 2019

jreback commented Sep 10, 2019

simonjayhawkins left a comment

WillAyd left a comment

simonjayhawkins commented Sep 12, 2019

simonjayhawkins commented Sep 12, 2019

simonjayhawkins commented Sep 12, 2019

vaibhavhrt commented Sep 13, 2019

Annotate DataFrame (Part 1) #26867

Annotate DataFrame (Part 1) #26867

Conversation

vaibhavhrt commented Jun 15, 2019 • edited Loading

vaibhavhrt left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Jun 15, 2019

Codecov Report

codecov bot commented Jun 15, 2019 • edited Loading

Codecov Report

WillAyd left a comment

Choose a reason for hiding this comment

vaibhavhrt left a comment

Choose a reason for hiding this comment

vaibhavhrt commented Jul 17, 2019

pep8speaks commented Jul 17, 2019 • edited Loading

Comment last updated at 2019-09-12 15:57:32 UTC

vaibhavhrt left a comment

Choose a reason for hiding this comment

vaibhavhrt commented Aug 28, 2019

jreback commented Sep 10, 2019

simonjayhawkins left a comment

Choose a reason for hiding this comment

WillAyd left a comment

Choose a reason for hiding this comment

simonjayhawkins commented Sep 12, 2019

simonjayhawkins commented Sep 12, 2019

simonjayhawkins commented Sep 12, 2019

vaibhavhrt commented Sep 13, 2019

vaibhavhrt commented Jun 15, 2019 •

edited

Loading

vaibhavhrt left a comment •

edited

Loading

codecov bot commented Jun 15, 2019 •

edited

Loading

pep8speaks commented Jul 17, 2019 •

edited

Loading