Skip to content

Add type hints for (DataFrame|Series)._data #26871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2019

Conversation

topper-123
Copy link
Contributor

This PR add a type hint for (DataFrame|Series)._data and NDFrame.__init__. This makes it easier to work with the BlockManager in Pandas.

@codecov
Copy link

codecov bot commented Jun 15, 2019

Codecov Report

Merging #26871 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26871      +/-   ##
==========================================
- Coverage   91.88%   91.87%   -0.01%     
==========================================
  Files         179      179              
  Lines       50696    50699       +3     
==========================================
- Hits        46581    46579       -2     
- Misses       4115     4120       +5
Flag Coverage Δ
#multiple 90.46% <100%> (ø) ⬆️
#single 41.1% <100%> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/core/series.py 93.64% <100%> (ø) ⬆️
pandas/core/generic.py 94.2% <100%> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.84% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 430f0fd...9c7f9d7. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 15, 2019

Codecov Report

Merging #26871 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26871      +/-   ##
==========================================
- Coverage   91.88%   91.87%   -0.01%     
==========================================
  Files         179      179              
  Lines       50696    50699       +3     
==========================================
- Hits        46581    46579       -2     
- Misses       4115     4120       +5
Flag Coverage Δ
#multiple 90.46% <100%> (ø) ⬆️
#single 41.1% <100%> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/core/series.py 93.64% <100%> (ø) ⬆️
pandas/core/generic.py 94.2% <100%> (ø) ⬆️
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.84% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 430f0fd...8769366. Read the comment docs.

@topper-123 topper-123 marked this pull request as ready for review June 15, 2019 19:24
@topper-123 topper-123 added the Typing type annotations, mypy/pyright type checking label Jun 15, 2019
@topper-123 topper-123 added this to the 0.25.0 milestone Jun 15, 2019
@topper-123 topper-123 changed the title Add type hints for (NDFrame|Series)._data Add type hints for (DataFrame|Series)._data Jun 15, 2019
@topper-123 topper-123 force-pushed the add_types_for_NDFrame._data branch from 9c7f9d7 to 8769366 Compare June 15, 2019 23:04
@jreback jreback merged commit 3381c64 into pandas-dev:master Jun 16, 2019
@jreback
Copy link
Contributor

jreback commented Jun 16, 2019

thanks @topper-123

@topper-123 topper-123 deleted the add_types_for_NDFrame._data branch June 16, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants