Don't fail when plotting Series/DataFrame with no row #28226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this? |
randomstuff
force-pushed
the
empty_plot
branch
from
f43abe5 to
523b3cd
Compare
|
Hello @randomstuff! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-08-30 21:04:52 UTC |
|
Yes, I was actually wondering how I should properly test this (and how the plot tests are done). I have added very basic tests. |
randomstuff
force-pushed
the
empty_plot
branch
from
523b3cd to
1af5d08
Compare
randomstuff
force-pushed
the
empty_plot
branch
4 times, most recently
from
9dbf7dc to
4384514
Compare
When Series or DataFrames was empty (no cells) after removing columns without a suitable type (.select_dtypes), pandas was throwing a "no numeric data to plot" exception. This can happen: 1) either because there is no column with a suitable type; 2) or if there is no row. Raising an exception in the first case makes sense but we should probably avoid throwing an exception in the second case.
randomstuff
force-pushed
the
empty_plot
branch
from
4384514 to
b647c39
Compare
|
Thanks @randomstuff! |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
|
Which exact pandas version was this added in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Series or DataFrames was empty (no cells) after removing columns
without a suitable type (.select_dtypes), pandas was throwing a "no
numeric data to plot" exception.
This can happen:
either because there is no column with a suitable type;
or if there is no row.
Raising an exception in the first case makes sense but we should
probably avoid throwing an exception in the second case.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff