Skip to content

DOC: fix PR09,PR08 docstring errors in pandas.plotting #28689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

josibake
Copy link

fixes the errors along with minor changes to standardize kwds -> **kwargs
closes #28687

verified this fixes PR09,PR08 errors with:

./scripts/validate_docstrings.py --errors=PR09,PR08 | grep "pandas.plotting"
  • closes #xxxx
  • tests added / passed

Josiah Baker and others added 2 commits September 30, 2019 11:47
@josibake
Copy link
Author

this is related to #27977 and #28602 (adding for visibility)

Josiah Baker added 5 commits September 30, 2019 12:52
actual parameters ordering doesnt match docstring ordering
fixes the errors along with minor changes to standardize kwds -> **kwargs
closes pandas-dev#28687
actual parameters ordering doesnt match docstring ordering
forgot to run black
@josibake josibake changed the title fix PR09,PR08 docstring errors in pandas.plotting DOC: fix PR09,PR08 docstring errors in pandas.plotting Sep 30, 2019
@WillAyd WillAyd added the Docs label Oct 1, 2019
@WillAyd WillAyd added this to the 1.0 milestone Oct 1, 2019
@josibake josibake requested a review from WillAyd October 1, 2019 04:56
@WillAyd WillAyd merged commit 78b2049 into pandas-dev:master Oct 1, 2019
@WillAyd
Copy link
Member

WillAyd commented Oct 1, 2019

Thanks @josibake !

josibake pushed a commit to josibake/pandas that referenced this pull request Oct 1, 2019
@josibake josibake deleted the docstring-pr09-pr08-pandas-plotting-fix branch October 1, 2019 18:14
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Docstrings Formatting Error PR09,PR08 in pandas.plotting
3 participants