Skip to content

FIX: Added small corrections to the test for interpolate limit_area #30987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2020
Merged

FIX: Added small corrections to the test for interpolate limit_area #30987

merged 1 commit into from
Jan 13, 2020

Conversation

cchwala
Copy link
Contributor

@cchwala cchwala commented Jan 13, 2020

  • closes # nothing to close here
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry # not required for this minor fix

Some tm.assert_series_equal() have been forgotten in

pandas/pandas/tests/series/test_missing.py

Line 1338 in 2baf788

def test_interp_limit_area(self):

There was also a typo in

pandas/pandas/tests/series/test_missing.py

Line 1374 in 2baf788

method="linear", limit_area="outside", direction="backward"
where direction has to be limit_direction.

These things have been fixed in this small PR.

WillAyd
WillAyd approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added the Testing pandas testing functions or related to the test suite label Jan 13, 2020
@WillAyd WillAyd added this to the 1.1 milestone Jan 13, 2020
@WillAyd WillAyd merged commit 2075539 into pandas-dev:master Jan 13, 2020
@WillAyd
Copy link
Member

WillAyd commented Jan 13, 2020

Thanks @cchwala

@cchwala cchwala deleted the correct_interpolate_limit_area_tests branch January 13, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@cchwala @WillAyd