REF: collect boilerplate in _datetimelike_compat #37723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Nov 10, 2020
| @@ -367,6 +367,32 @@ def _wrap_results(result, dtype: np.dtype, fill_value=None): | |||
| return result | |||
|
|
|||
|
|
|||
| def _datetimelike_compat(func): | |||
There was a problem hiding this comment.
FYI i don't think this needs to be private, but nbd.
There was a problem hiding this comment.
also as a follow up need to ensure decorator preserves types #33455
There was a problem hiding this comment.
will do follow-up to annotate new_func. can we start typing mask as np.ndarray[bool] or something like that?
There was a problem hiding this comment.
The important thing is that the decoratored function signature is preserved. It may not be so important, in the grand scheme of things, to type check this function. though can do as well.
jreback
added
Clean
Numeric Operations
|
this is nice |
jbrockmendel
added a commit
that referenced
this pull request
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.