REGR: preserve Int32 dtype on setitem #42166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Jun 21, 2021
jbrockmendel
commented
- closes BUG: Adding Series to empty DataFrame can reset dtype to float64 #42099
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
simonjayhawkins
added
the
Regression
jreback
added
Dtype Conversions
jreback
reviewed
Jun 21, 2021
| @@ -1660,6 +1664,21 @@ def _setitem_with_indexer(self, indexer, value, name="iloc"): | |||
| if com.is_null_slice(indexer[0]): | |||
| # We are setting an entire column | |||
| self.obj[key] = value | |||
| return | |||
| elif is_array_like(value): | |||
There was a problem hiding this comment.
this is getting super messy, but i guess ok
|
@meeseeksdev backport 1.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jun 21, 2021
|
Something went wrong ... Please have a look at my logs. |
neinkeinkaffee
pushed a commit
to neinkeinkaffee/pandas
that referenced
this pull request
Jun 21, 2021
jreback
pushed a commit
that referenced
this pull request
Jun 21, 2021
Co-authored-by: jbrockmendel <[email protected]>
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.