Skip to content

TYP: type some un-typed decorators #43400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 10, 2021
Merged

TYP: type some un-typed decorators #43400

merged 4 commits into from
Sep 10, 2021

Conversation

twoertwein
Copy link
Member

@twoertwein twoertwein commented Sep 4, 2021 •
edited
Loading

@twoertwein twoertwein added the Typing type annotations, mypy/pyright type checking label Sep 4, 2021
MarcoGorelli
MarcoGorelli reviewed Sep 4, 2021
View reviewed changes
MarcoGorelli
MarcoGorelli approved these changes Sep 4, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @twoertwein , looks fine to me

@jreback jreback added this to the 1.4 milestone Sep 4, 2021
@jreback jreback merged commit 449eaae into pandas-dev:master Sep 10, 2021
@jreback
Copy link
Contributor

jreback commented Sep 10, 2021

thanks @twoertwein

@twoertwein twoertwein deleted the decorators branch September 22, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@twoertwein @jreback @MarcoGorelli