Skip to content

PERF: use C version of np.empty #46878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2022
Merged

PERF: use C version of np.empty #46878

merged 1 commit into from
Apr 27, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

WillAyd
WillAyd approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Is this something that can be wrapped upstream in Cython too?

@jbrockmendel
Copy link
Member Author

Is this something that can be wrapped upstream in Cython too?

I've considered making a helper function empty_1d and putting in util.pxd, haven't thought about upstreaming it.

@jreback jreback added this to the 1.5 milestone Apr 27, 2022
@jreback jreback added the Performance Memory or execution speed performance label Apr 27, 2022
@jreback jreback merged commit 4fcc8d5 into pandas-dev:main Apr 27, 2022
@jbrockmendel jbrockmendel deleted the less-np branch April 27, 2022 14:55
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jbrockmendel @yehoshuadimarsky
PERF: use C version of np.empty (pandas-dev#46878)
5be1742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Performance Memory or execution speed performance
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @WillAyd @jreback