-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI: Debug CI ImportError #47310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Debug CI ImportError #47310
Conversation
Last build of Docstrings and typing validation failed but ASV Benchmarks was successful. Good build: Symbols in np_datetime.o
Symbols in np_datetime.so
Symbols in timestamps.so
Bad build: Symbols in np_datetime.o
Symbols in np_datetime.so
Symbols in timestamps.so
|
@rhshadrach great debugging on this. I think the main thing of importance here is the symbol table for 0000000000018[39](https://github.com/pandas-dev/pandas/runs/6844281121?check_suite_focus=true#step:9:40)0 T pandas_datetime_to_datetimestruct Whereas the bad build has U pandas_datetime_to_datetimestruct The "T" vs "U" distinction here is important; "U" occurs when you try to link object files (.o on Unix) but the symbol you want placed into the shared library (.so) is not found in any of the .o files. My guess here is that we have a race condition between the linking stage looking for With all of that said, I don't know what the immediate fix could be for setuptools. Life is definitely much easier in the CMake / Meson world with this. We could certainly re-examine the build toolchain in setup.py as is and make sure that files that re-generate |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.