Skip to content

DOC: Plotting / Visualization without Jupyter #47948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 9, 2022

Conversation

tpackard1
Copy link
Contributor

@tpackard1 tpackard1 commented Aug 3, 2022

Added a note at the top of the page clarifying that the examples assume you're working jupyter. @MarcoGorelli asked to be tagged to this PR. Hopefully I did everything correctly as this is my first PR.

Added a note at the top of the page clarifying that the examples assume you're working jupyter.
@MarcoGorelli MarcoGorelli changed the title Update visualization.rst DOC: Plotting / Visualization without Jupyter Aug 3, 2022
@MarcoGorelli
Copy link
Member

Looks like there's an (unrelated) doc build failure, will revisit this later once that's fixed

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tpackard1 , I downloaded the artifact and can confirm this renders fine

@MarcoGorelli MarcoGorelli added this to the 1.5 milestone Aug 4, 2022
@nwoodweb
Copy link

nwoodweb commented Aug 5, 2022

Hi @MarcoGorelli @tpackard1 ,

should we also mention the plt.savefig() function, which allows one to save the pandas object as an image file? This is useful if executed either in a script or in the Python interpreter command line.

We can probably copy and paste from a push I made on my fork.

@MarcoGorelli
Copy link
Member

Hi @MarcoGorelli @tpackard1 ,

should we also mention the plt.savefig() function, which allows one to save the pandas object as an image file? This is useful if executed either in a script or in the Python interpreter command line.

We can probably copy and paste from a push I made on my fork.

I think that looks good, thanks - at this point I think the simplest thing would be for you to suggest changes on this PR, so then you'll end up as co-committer

In the future, please comment take on issues you're working on so the issue is assigned to you - in this case, I'd forgotten that you'd already commented that you were working on this, apologies

.. note::

The examples below assume that you're using `Jupyter <https://jupyter.org/>`_.

Copy link

@nwoodweb nwoodweb Aug 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If one is implementing a script or is executing the Python interpreter
from a command line interface, one may opt for ``plt.savefig('$filename')``
in lieu of the ``$object.plot()`` functions found in this tutorial.
``plt.savefig()`` saves the pandas object as an image and accepts a variety
of filetypes, including png, pdf, jpg, and svg.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite right, there's a button to press to suggest changes, check the article I linked (step 6)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO I don't think this note is entirely necessary. Since the rest of the documentation mentions using the matplotlib API, I think further matplotlib actions can be independently looked-up by the user.

Copy link
Member

@MarcoGorelli MarcoGorelli Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point - let's keep as-is then and land this

@MarcoGorelli MarcoGorelli merged commit 095710d into pandas-dev:main Aug 9, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
* Update visualization.rst

Added a note at the top of the page clarifying that the examples assume you're working jupyter.

* Update doc/source/user_guide/visualization.rst

* capitalise Jupyter

Co-authored-by: Marco Edward Gorelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Plotting / Visualization without Jupyter
4 participants