REF: make indicator_name a cache_readonly #48040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 12, 2022
| @@ -753,6 +744,17 @@ def _maybe_drop_cross_column( | |||
| if cross_col is not None: | |||
| del result[cross_col] | |||
|
|
|||
| @cache_readonly | |||
There was a problem hiding this comment.
Aside, maybe we can use
from functools import cache (PY3.9)/ lru_cache
@property
@lru_cache(maxsize=None)/@cache
def _indicator_name(...)
in the future instead
There was a problem hiding this comment.
There was a problem hiding this comment.
Specific to here or replace cache_readonly in general?
There was a problem hiding this comment.
To replace cache_readonly in general. Could gain some nice benefits like cache clearing and thread safety (if I'm viewing the implementation correctly)
mroeschke
approved these changes
Aug 12, 2022
mroeschke
added
Refactor
|
Thanks @jbrockmendel |
YYYasin19
pushed a commit
to YYYasin19/pandas
that referenced
this pull request
Aug 23, 2022
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too much going on in
__init__ATM.