Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDEP0004: implementation #49024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDEP0004: implementation #49024
Changes from 41 commits
ea79669
bb68cc3
82266f4
4a6f198
5568dca
bc910b0
7d03503
ac825f5
2ffcef6
060835d
1d9f274
b3e32ac
22417cf
d3adfe5
affa7f3
575b215
f0e83da
a5ff448
68a6ea2
6661ae3
1d255e0
b3aa585
285b1ff
963b62b
c90a8a5
3c033ff
cdfa355
434c6f0
5755032
96c0653
9f1c18e
0a86705
7b4d6be
86e9bcf
f92a8cb
fd215df
0a5c466
772dd6c
b49b7cf
17f5e74
d17d819
f4520e9
fcb515f
78b4b9e
2215652
1ec70db
7b0eb99
7d11f59
30e6f39
f0ac458
92ef7e2
4a5dd1c
917b31b
135bbb5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this line still necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it's an example demonstrating that
dayfirst
isn't strictbut it's good you've highlighted this, as the blank line I'd removed was preventing it from rendering properly. now it looks fine:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbrockmendel thanks for your review - any other objections? Sorry to tag, just hoping to move this forwards before more merge conflicts arise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good here. ill take another look tomorrowish if this is still up, but if it is merged before then i wont complain