Updated release instructions to use rst instead of markdown #50886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Thanks for working on this @tpackard1. Looks great, only one minor comment that I think will make the next comment easier to understand (I was a bit confused first).
| Open a PR updating the build commit to the released version, and merge it once the | ||
| CI is green. | ||
| CI is green to do this type:: |
There was a problem hiding this comment.
Suggested change
| CI is green to do this type:: | |
| CI is green. To do this type:: |
tpackard1
force-pushed
the
release-process-formatted
branch
from
6a54502 to
ecd3212
Compare
mroeschke
reviewed
Jan 20, 2023
| - Permissions to push to main in the pandas repository, to push the new tags. | ||
| - Write permissions to [PyPI](https://github.com/conda-forge/pandas-feedstock/pulls) | ||
| - Write permissions to `PyPI <https://github.com/conda-forge/pandas-feedstock/pulls>`_ |
There was a problem hiding this comment.
Suggested change
| - Write permissions to `PyPI <https://github.com/conda-forge/pandas-feedstock/pulls>`_ | |
| - `Write permissions to PyPI <https://github.com/conda-forge/pandas-feedstock/pulls>`_ |
To avoid
2023-01-20T05:53:13.6374953Z /home/runner/work/pandas/pandas/doc/source/development/maintaining.rst:5: WARNING: Duplicate explicit target name: "pypi".
There was a problem hiding this comment.
Thanks @mroeschke! I will make the change rn
|
Thanks @tpackard1 |
pooja-subramaniam
pushed a commit
to pooja-subramaniam/pandas
that referenced
this pull request
Jan 25, 2023
…ev#50886) * rst formatted release instructions * updated release instructions line 456 * avoid duplicate explicit target name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@datapythonista I tried to fix the other pull request but made a mess of it so I thought it would be best to start over. If this was the wrong, please let me know what should have been done; still learning the GitHub/ git workflow.