Skip to content

DEPS: Filter numpy's FutureWarning from array_equal #52010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 16, 2023

Conversation

mroeschke
Copy link
Member

Looks to be failing on the numpy dev build

The warning is from np.array_equal raising it's own FutureWarning: numpy/numpy#23401

@mroeschke mroeschke added this to the 2.0 milestone Mar 16, 2023
@mroeschke mroeschke added Warnings Warnings that appear or should be added to pandas Upstream issue Issue related to pandas dependency labels Mar 16, 2023
@jbrockmendel
Copy link
Member

LGTM pending green

@mroeschke
Copy link
Member Author

Looks like the numpy dev build is installing a non-numpy dev version for some reason: https://github.com/pandas-dev/pandas/actions/runs/4432829243/jobs/7777266394

Requirement already satisfied: numpy>=1.21.0 in /home/runner/micromamba/envs/test/lib/python3.10/site-packages (from pandas==2.1.0.dev0+239.g69b7019c10) (1.24.2)

@mroeschke mroeschke modified the milestones: 2.0, 2.1 Mar 16, 2023
@mroeschke mroeschke changed the title DEPS/CI: Filter numpy's FutureWarning from array_equal DEPS: Filter numpy's FutureWarning from array_equal Mar 16, 2023
@mroeschke
Copy link
Member Author

Looked to have been an environment solve/cache issue, but I suppose this could be useful to still filter this out.

@phofl
Copy link
Member

phofl commented Mar 16, 2023

The 2.0.x build is still failing as of this morning, so merging and backporting

@phofl phofl modified the milestones: 2.1, 2.0 Mar 16, 2023
@phofl phofl merged commit ebfcad1 into pandas-dev:main Mar 16, 2023
@phofl phofl mentioned this pull request Mar 16, 2023
1 task
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 16, 2023
@phofl
Copy link
Member

phofl commented Mar 16, 2023

thx @mroeschke

@phofl
Copy link
Member

phofl commented Mar 16, 2023

Purging the cache there helped as well

@phofl phofl modified the milestones: 2.0, 2.1 Mar 16, 2023
@mroeschke mroeschke deleted the deps/np/errant_futurewarning branch March 16, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Upstream issue Issue related to pandas dependency Warnings Warnings that appear or should be added to pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants