Skip to content

DEPR: groupby with as_index=False not including out-of-axis groupings #52333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 17, 2023
Merged

DEPR: groupby with as_index=False not including out-of-axis groupings #52333

merged 7 commits into from
Apr 17, 2023

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach commented Mar 31, 2023 •
edited
Loading

cc @jorisvandenbossche

I only took a cursory look, but I'm hopeful when this deprecation is enforced that we will be able to remove all internal notions of in_axis groupings.

@rhshadrach rhshadrach added Groupby Deprecate Functionality to remove in pandas labels Mar 31, 2023
@rhshadrach rhshadrach added this to the 2.1 milestone Mar 31, 2023
mroeschke
mroeschke reviewed Apr 15, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the merge conflict

@rhshadrach
Merge branch 'main' of https://github.com/pandas-dev/pandas into grou…
540674b 
…pby_out_axis_groupers

� Conflicts:
�	doc/source/whatsnew/v2.1.0.rst
@rhshadrach
Merge branch 'groupby_out_axis_groupers' of https://github.com/rhshad…
734db24 
…rach/pandas into groupby_out_axis_groupers

� Conflicts:
�	doc/source/whatsnew/v2.1.0.rst
@mroeschke mroeschke merged commit 4017e9c into pandas-dev:main Apr 17, 2023
@mroeschke
Copy link
Member

Thanks @rhshadrach

@rhshadrach rhshadrach deleted the groupby_out_axis_groupers branch April 17, 2023 20:44
@rhshadrach rhshadrach mentioned this pull request Apr 22, 2023
Open
@rhshadrach rhshadrach mentioned this pull request Jun 14, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke left review comments

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Groupby
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

DEPR: groupby with as_index=False doesn't add grouper as column when passing a Series as group key
2 participants
@rhshadrach @mroeschke