BUG: dtype of DataFrame.idxmax/idxmin incorrect for empty frames #53296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added examples for Interval and IntervalArray * changed code_checks.sh * forgot these
mroeschke
reviewed
May 19, 2023
ci/code_checks.sh
Outdated
| @@ -172,16 +172,6 @@ if [[ -z "$CHECK" || "$CHECK" == "docstrings" ]]; then | |||
| pandas.Period.asfreq \ | |||
| pandas.Period.now \ | |||
| pandas.arrays.PeriodArray \ | |||
| pandas.Interval.closed \ | |||
There was a problem hiding this comment.
Looks like this shouldn't be included here?
There was a problem hiding this comment.
Yeah, something in the rebase went wrong. I’ve updated…
mroeschke
approved these changes
May 22, 2023
|
Thanks @topper-123 |
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
May 22, 2023
…das-dev#53296) * BUG: dtype of DataFrame.idxmax/idxmin incorrect for empty frames * simplify * fix groupby test failures * DOC: Fixing EX01 - Added examples (pandas-dev#53292) * Added examples for Interval and IntervalArray * changed code_checks.sh * forgot these * fix DataFrame.[idxmax|idxmin] --------- Co-authored-by: Dea María Léon <[email protected]>
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…das-dev#53296) * BUG: dtype of DataFrame.idxmax/idxmin incorrect for empty frames * simplify * fix groupby test failures * DOC: Fixing EX01 - Added examples (pandas-dev#53292) * Added examples for Interval and IntervalArray * changed code_checks.sh * forgot these * fix DataFrame.[idxmax|idxmin] --------- Co-authored-by: Dea María Léon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.