BLD: Add Cython Coverage option #54453
Conversation
lithomas1
requested review from
MarcoGorelli,
WillAyd and
mroeschke
as code owners
|
You need to specify it as a option. For debug builds and Cython Coverage enabled you can do |
| @@ -325,7 +325,7 @@ cdef double round_trip_wrapper(const char *p, char **q, char decimal, | |||
|
|
|||
| cdef void* buffer_rd_bytes_wrapper(void *source, size_t nbytes, | |||
| size_t *bytes_read, int *status, | |||
| const char *encoding_errors) noexcept: | |||
| const char *encoding_errors) noexcept nogil: | |||
There was a problem hiding this comment.
Needed to mark this as nogil or we would segfault since the tracing code would try to use GIL requiring code (and this function would be called in a nogil block).
I'm pretty sure the C code can acquire the GIL for itself when it needs it so nogil isn't needed?
cc @WillAyd
There was a problem hiding this comment.
Yea it looks like the C code does ensure the GIL. I'm a little unclear then though - isn't marking this nogil incorrect since it actually uses the GIL?
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Closing to clear the queue, but feel free to reopen if you have time to circle back |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.