-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
enable ASAN/UBSAN in pandas CI #55102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
66d83d1
7aa2e7a
a5b3808
7b58c6d
18111b0
438cdfa
b18cf9d
69cb6f6
6f5fb11
eb258ca
663d6d4
466056d
91f2e17
d4074ca
aeff50e
e303ba1
4220d82
46d1034
89706a4
929c731
b01242b
6483e07
de13605
b87a210
77d1e00
46ec023
8695dca
05319ae
6d76a57
f5dd440
12aa1d1
628d1c2
1de633e
3e295c5
252197e
d5809b8
6266422
b68a533
47dc305
636b8dd
a03ad1e
656edb1
2aabda1
a9f2419
3056e5f
89b2b80
d591b78
6442066
c59703d
02bf20d
01070f3
9f1adbc
57ed286
677da0e
af0150a
4647f12
cba79f6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -154,22 +154,36 @@ jobs: | |
with: | ||
environment-file: ci/deps/${{ matrix.env_file }} | ||
|
||
- name: Set sanitizer flags | ||
run: | | ||
echo "CFLAGS=$CFLAGS -fno-sanitize-recover=all" >> "$GITHUB_ENV" | ||
- name: echo flags | ||
run: | | ||
printf '%s\n' "CFLAGS" | ||
- name: Build Pandas | ||
id: build | ||
uses: ./.github/actions/build_pandas | ||
env: | ||
CFLAGS: "$CFLAGS" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IIRC, this doesn't set CFLAGS inside of the action. It just makes CFLAGS available under Why don't you try setting CFLAGs in action.yml directly if sanitize = true? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah great idea - much cleaner |
||
with: | ||
sanitize: true | ||
|
||
- name: Test (not single_cpu) | ||
uses: ./.github/actions/run-tests | ||
if: ${{ matrix.name != 'Pypy' }} | ||
env: | ||
# Set pattern to not single_cpu if not already set | ||
PATTERN: ${{ env.PATTERN == '' && 'not single_cpu' || matrix.pattern }} | ||
ASAN_OPTIONS: detect_leaks=0 | ||
LD_PRELOAD: $(gcc -print-file-name=libasan.so) | ||
|
||
- name: Test (single_cpu) | ||
uses: ./.github/actions/run-tests | ||
env: | ||
PATTERN: 'single_cpu' | ||
PYTEST_WORKERS: 0 | ||
ASAN_OPTIONS: detect_leaks=0 | ||
LD_PRELOAD: $(gcc -print-file-name=libasan.so) | ||
if: ${{ matrix.pattern == '' && (always() && steps.build.outcome == 'success')}} | ||
|
||
macos-windows: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having trouble setting this with GHA. There may also be a way to pass the flag directly through meson python? @lithomas1 any idea?