-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: Add numba engine to df.apply #55104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
1fa802c
ENH: Add numba engine to df.apply
lithomas1 c6af7c9
Merge branch 'main' of github.com:pandas-dev/pandas into numba-apply
lithomas1 0ac544d
complete?
lithomas1 31b9e20
wip: pass tests
lithomas1 6190772
Merge branch 'main' of github.com:pandas-dev/pandas into numba-apply
lithomas1 55df7ad
fix existing tests
lithomas1 3c89b0f
go for green
lithomas1 1418d3e
fix checks?
lithomas1 c143c67
fix pyright
lithomas1 0d827c4
update docs
lithomas1 7129ee8
Merge branch 'main' of github.com:pandas-dev/pandas into numba-apply
lithomas1 b0ba283
Merge branch 'main' into numba-apply
lithomas1 f4e80a6
eliminate a blank line
lithomas1 21e2186
update from code review + more tests
lithomas1 b60bef8
Merge branch 'main' of github.com:pandas-dev/pandas into numba-apply
lithomas1 ba1d0e0
fix failing tests
lithomas1 088d27f
Simplify w/ context manager
lithomas1 60539a1
skip if no numba
lithomas1 76538d6
simplify more
lithomas1 cca34f9
specify dtypes
lithomas1 8b423bf
Merge branch 'main' of github.com:pandas-dev/pandas into numba-apply
lithomas1 f135def
Merge branch 'main' into numba-apply
lithomas1 b2e50d2
Merge branch 'numba-apply' of github.com:lithomas1/pandas into numba-…
lithomas1 f86024f
address code review
lithomas1 a15293d
add errors for invalid columns
lithomas1 8fe5d89
adjust message
lithomas1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? (and below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out!
I think for now it'll probably make better sense to disable parallel mode for now, since the dict in numba isn't thread-safe.
The overhead from the boxing/unboxing is also really high (99% of the time spent is there), so I doubt parallel will give a good speedup, at least for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK makes sense. Would be good to put a TODO: comment explaining why we shouldn't use prange for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a comment.