BUG: DataFrame.update doesn't preserve dtypes #55558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve dtype when updating from dataframe whose NA values don't affect original. I don't know the best place to put the test case in the tests/frame or the tests/dtype directory. Signed-off-by: Michael Tiemann <[email protected]>
|
I found pandas/tests/frame/methods/test_update.py and will update test case there. |
simonjayhawkins
changed the title
simonjayhawkins
added
Bug
Dtype Conversions
Created generic test case that probes a number of basic types, not only `bool` (original report). Signed-off-by: Michael Tiemann <[email protected]>
It appears that only `bool` and `datetime64` dtypes need special handling to pass `test_update_preserve_dtype`, so no need to see whether int, float, complex, string, or other types need fixing. Signed-off-by: Michael Tiemann <[email protected]>
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
My changes obsoleted by #55634 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve dtype when updating from dataframe whose NA values don't affect original.
I don't know the best place to put the test case in the tests/frame or the tests/dtype directory.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.