DEPR: PeriodIndex ordinal, fields keywords #55963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Nov 15, 2023
| @@ -146,7 +148,7 @@ class PeriodIndex(DatetimeIndexOpsMixin): | |||
|
|
|||
| Examples | |||
| -------- | |||
| >>> idx = pd.PeriodIndex(year=[2000, 2002], quarter=[1, 3]) | |||
| >>> idx = pd.PeriodIndex.from_fields(year=[2000, 2002], quarter=[1, 3]) | |||
There was a problem hiding this comment.
Could you add a .. deprecated 2.2.0 directive in the docstring for the fields?
mroeschke
reviewed
Nov 15, 2023
| @@ -280,6 +295,39 @@ def __new__( | |||
|
|
|||
| return cls._simple_new(data, name=name, refs=refs) | |||
|
|
|||
| @classmethod | |||
| def from_fields( | |||
There was a problem hiding this comment.
Could you add this method and from_ordinals to the API reference?
mroeschke
added
Period
mroeschke
approved these changes
Nov 15, 2023
|
Thanks @jbrockmendel |
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Nov 15, 2023
* DEPR: PeriodIndex ordinal, fields keywords * lint fixups * update doctest * doc updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.