TST update and simplify consortium api test #55993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
simplify-standard-test
branch
from
d9bdac0 to
7cb4532
Compare
mroeschke
approved these changes
Nov 16, 2023
mroeschke
added
Testing
|
Thanks @MarcoGorelli |
|
@meeseeksdev backport to 2.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Nov 22, 2023
MarcoGorelli
added a commit
that referenced
this pull request
Nov 22, 2023
…m api test) (#56112) Backport PR #55993: TST update and simplify consortium api test Co-authored-by: Marco Edward Gorelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's quite likely that the dataframe api will have a
Scalarclass, and thatColumn.get_valuewill return thatI'm suggesting to just simplify the test to make an assertion about
Column.name, which realistically isn't going to changeDocs CI failure is unrelated and due to scipy/docs.scipy.org#80