ENH: scatter_matrix new parameter nondiagonal to allow hexbin plots i…

[shadiakiki1986]

…nstead of scatter

• closes ENH: pandas.plotting.scatter_matrix to support plotting function hexbin in addition to scatter #56887 (Replace xxxx with the GitHub issue number)
• Tests added and passed if fixing a bug or adding a new feature
  • running the tests gives an error unrelated to my development: ModuleNotFoundError: No module named 'pandas._libs.pandas_parser'

ImportError while loading conftest '/workspaces/pandas/pandas/conftest.py'.
pandas/__init__.py:49: in <module>
    from pandas.core.api import (
pandas/core/api.py:1: in <module>
    from pandas._libs import (
pandas/_libs/__init__.py:16: in <module>
    import pandas._libs.pandas_parser  # isort: skip # type: ignore[reportUnusedImport]
E   ModuleNotFoundError: No module named 'pandas._libs.pandas_parser'

• All code checks passed.
  • same issue as tests
• Added type annotations to new arguments/methods/functions.
• Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.
  • didn't add yet

[bhattbhuwan13]

I have the same issue. I can import pandas normally if i switch to the parent directory(the one just outside the root pandas directory) but when I try to import pandas from the directory containing the requirements file, it fails with the same error

[mroeschke]

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

[shadiakiki1986]

@mroeschke
Merged. Failed tests were unrelated to the edits in this PR

[github-actions]

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

[shadiakiki1986]

I'm not sure how to react to this. We already went through the cycle of updating the branch. Feels like the start of an infinite loop.

…

On Fri, Mar 29, 2024, 20:05 github-actions[bot] ***@***.***> wrote: This pull request is stale because it has been open for thirty days with no activity. Please update <https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request> and respond to this comment if you're still interested in working on this. — Reply to this email directly, view it on GitHub <#56888 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACAA5BHSLJW6GWXEIR3DSY3Y2X6VRAVCNFSM6AAAAABB3JF2YKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXHAZTGNRZHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[mroeschke]

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

[shadiakiki1986]

Is this an automated response?

…

On Tue, Apr 23, 2024, 14:46 Matthew Roeschke ***@***.***> wrote: Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. — Reply to this email directly, view it on GitHub <#56888 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACAA5BFVUFMAIFFQL3I6PRTY62UADAVCNFSM6AAAAABB3JF2YKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZTGE4DCOJVGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>