-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: Remove redundant check #57156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Remove redundant check #57156
Conversation
Thanks for the work on this @tqa236. I only see one of the errors failing in the CI. Is this working as expected? |
hello @datapythonista , the CI works as expected. The 2 errors are caught by
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying @tqa236, I was checking the Code checks
job in GitHub actions, I didn't see that. Good to see this simplified.
Looks good to me then, feel free to revert the errors.
083efd5
to
4754b86
Compare
thanks for the review, @datapythonista, I reverted the last commit. The PR is ready. |
Thanks again @tqa236 If interested, it would be great to see what ruff (pylint) checks are covered by what is run by pylint. It would be great if we could just switch over to ruff with most of the rules being covered |
@mroeschke I can look into it. Do you mind if I bump |
Go for it. I am happy to keep that branch updated with whatever changes you make |
Remove redundant code style check
I removed 2 checks that's already covered in
ruff
'sPGH003
andPGH004
The second commit is just an example that the check works. Will revert before merging if approved.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.