BUG: Interchange object data buffer has the wrong dtype / from_dataframe incorrect #57570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Feb 22, 2024
Comment on lines
-56
to
-62
| - id: check-ast | ||
| - id: check-case-conflict | ||
| - id: check-toml | ||
| - id: check-xml | ||
| - id: check-yaml | ||
| exclude: ^ci/meta.yaml$ | ||
| - id: debug-statements |
There was a problem hiding this comment.
drive-by: these are already covered by ruff 😎
MarcoGorelli
force-pushed
the
breaking-interchange-fixes
branch
from
3b82c94 to
28556c2
Compare
WillAyd
reviewed
Feb 22, 2024
| 8, | ||
| ArrowCTypes.UINT8, | ||
| Endianness.NATIVE, | ||
| ) # note: currently only support native endianness |
There was a problem hiding this comment.
Are we planning to ever support anything but that as an exporter?
There was a problem hiding this comment.
I don't know tbh
cc @jorisvandenbossche in case you have comments on this
WillAyd
approved these changes
Feb 23, 2024
mroeschke
approved these changes
Feb 23, 2024
|
Thanks @MarcoGorelli |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…ame incorrect (pandas-dev#57570) string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from_dataframeincorrect #54781 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.