Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating timeseries.offset_aliases links to use :ref: format #57581

Merged

Conversation

jordan-d-murphy
Copy link
Contributor

During code review on #57562 it was suggested to update the links from this format

this link <https://pandas.pydata.org/pandas-docs/stable/user_guide/timeseries.html#offset-aliases>__.

to this format

:ref:this link<timeseries.offset_aliases>

I found several places where this same link was using this old format, so opened this PR to update them all for consistency.

@jordan-d-murphy
Copy link
Contributor Author

@mroeschke can you take a look at this PR? based off the suggestion in #57562

@jordan-d-murphy
Copy link
Contributor Author

pre-commit.ci autofix

@MarcoGorelli
Copy link
Member

/preview

Copy link
Contributor

Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/57581/

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, thanks @jordan-d-murphy !

@MarcoGorelli MarcoGorelli added this to the 3.0 milestone Feb 23, 2024
@MarcoGorelli MarcoGorelli merged commit a305c1f into pandas-dev:main Feb 23, 2024
@jordan-d-murphy jordan-d-murphy deleted the update_offset_aliases_links branch February 23, 2024 17:04
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants