Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: groupby.first/last unused compat #57589

Closed

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

It used to be that any op winding up in _cython_agg_general needed a fallback. This is no longer the case since first and last now handle object dtype in the Cython code and axis=1 has been removed.

Sorry, something went wrong.

@rhshadrach rhshadrach added this to the 3.0 milestone Feb 23, 2024
@rhshadrach
Copy link
Member Author

I was wrong - EAs are still falling back to apply. Opened #57591

@rhshadrach rhshadrach closed this Feb 23, 2024
@rhshadrach rhshadrach deleted the cln_groupby_first_last_compate branch February 28, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants