Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: datetime parsing fails on a leapday #57685

Closed

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

No idea what would be a better fix. dateutil_parse will substitute parts of the dt_str into default and then check if it's a valid date.

@datapythonista datapythonista added Bug Datetime Datetime data dtype labels Feb 29, 2024
@datapythonista
Copy link
Member

There is another PR also addressing this with a similar approach: #57674

@rhshadrach
Copy link
Member Author

Thanks - I quickly checked but missed that one. That approach is better.

@rhshadrach rhshadrach closed this Feb 29, 2024
@rhshadrach rhshadrach deleted the bug_datetime_parsing_leapday branch March 1, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Datetime Datetime data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants