Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix ci (calamine typing) #57689

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Mar 1, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

new calamine release is typed 🥳

@MarcoGorelli MarcoGorelli requested a review from rhshadrach as a code owner March 1, 2024 12:14
@MarcoGorelli MarcoGorelli added CI Continuous Integration Typing type annotations, mypy/pyright type checking labels Mar 1, 2024
@MarcoGorelli MarcoGorelli added this to the 2.2.2 milestone Mar 1, 2024
@MarcoGorelli
Copy link
Member Author

self-merging to fix ci

@MarcoGorelli MarcoGorelli merged commit ab2980b into pandas-dev:main Mar 1, 2024
51 of 53 checks passed
Copy link

lumberbot-app bot commented Mar 1, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.2.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 ab2980ba52ae24db72765b3c4ae1d33ac8fad3f5
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #57689: CI: fix ci (calamine typing)'
  1. Push to a named branch:
git push YOURFORK 2.2.x:auto-backport-of-pr-57689-on-2.2.x
  1. Create a PR against branch 2.2.x, I would have named this PR:

"Backport PR #57689 on branch 2.2.x (CI: fix ci (calamine typing))"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

MarcoGorelli added a commit to MarcoGorelli/pandas that referenced this pull request Mar 1, 2024
lithomas1 pushed a commit that referenced this pull request Mar 1, 2024
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant