Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: locking pytest version = 8.1.0 #57727

Conversation

natmokval
Copy link
Contributor

@natmokval natmokval commented Mar 4, 2024

locked pytest to version more then 8.1.0, as a temporary solution.

the reason: with the latest pytest version 8.1.0 we get an error when runninig pytest

File "/home/panda/miniforge3/envs/pandas-dev/lib/python3.10/site-packages/pluggy/_manager.py", line 342, in _verify_hook
    raise PluginValidationError(
pluggy._manager.PluginValidationError: Plugin 'pytest_cython' for hook 'pytest_collect_file'
hookimpl definition: pytest_collect_file(path, parent)
Argument(s) {'path'} are declared in the hookimpl but can not be found in the hookspec

I think, it’s a bug in the last version of pytest-cython-0.2.1 (see link)
which is related to enforcing deprecation of path parameter in the last version of pytest 8.1.0 (see link)

@natmokval natmokval marked this pull request as ready for review March 4, 2024 21:21
@mroeschke
Copy link
Member

I think the pytest devs just yanked 8.1 from pypi and conda forge so we may not need this anymore: pytest-dev/pytest#12069

e.g. https://github.com/pandas-dev/pandas/actions/runs/8146954729/job/22266609711#step:4:427

@natmokval natmokval changed the title CI: locking pytest to version less then 8.1.0 CI: locking pytest version = 8.1.0 Mar 4, 2024
@natmokval
Copy link
Contributor Author

indeed, seems we don't need this anymore. Thank you, @mroeschke, I will close this PR.

@natmokval natmokval closed this Mar 4, 2024
@mroeschke
Copy link
Member

Thanks for being proactive on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Pytest Version >=8.1
2 participants