Skip to content

REF: Use PyUnicode_AsUTF8AndSize instead of get_c_string_buf_and_size #58227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2024
Merged

REF: Use PyUnicode_AsUTF8AndSize instead of get_c_string_buf_and_size #58227

merged 3 commits into from
Apr 12, 2024

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added Internals Related to non-user accessible pandas implementation Clean labels Apr 11, 2024
@mroeschke mroeschke requested a review from MarcoGorelli as a code owner April 11, 2024 23:02
WillAyd
WillAyd reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment otherwise lgtm when green

pandas/_libs/tslibs/util.pxd Outdated
@@ -1,6 +1,9 @@

from cpython.object cimport PyTypeObject
from cpython.unicode cimport PyUnicode_AsUTF8AndSize
from cpython.unicode cimport (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these imports are superfluous here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Removed

@WillAyd WillAyd merged commit 4fe49b1 into pandas-dev:main Apr 12, 2024
46 checks passed
@WillAyd
Copy link
Member

WillAyd commented Apr 12, 2024

Thanks @mroeschke

@mroeschke mroeschke deleted the rm/get_cstring_buf_and_size branch April 12, 2024 00:52
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@mroeschke @pmhatre1
REF: Use PyUnicode_AsUTF8AndSize instead of get_c_string_buf_and_size (…
387e356 
…pandas-dev#58227)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli

Assignees
No one assigned
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @WillAyd