BLD: fix cythonized msgpack extension in setup.py GH5831 #5844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks completely logical and seems to help! ;) I will do proper rebuild across to see if no side-effects (although once again -- logical, so I am not expecting any ;) ) |
|
no word from @yarikoptic, tested well for me. I'm going to pull the trigger on this one. What could possibly happen?? |
ghost
pushed a commit
that referenced
this pull request
Jan 10, 2014
BLD: fix cythonized msgpack extension in setup.py GH5831
ghost
merged commit
|
as I said -- it was so logical ;-) I think this aspect indeed was resolved for me as well |
|
no worries. |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5831
@yarikoptic, can you confirm this fixes the problem?